Proxmox inv fix agent string parsing (#2245)

* Added handling for commas in the agent field for agent configuration

* Removed test statement

* Added changelog fragment

* Fixed spelling on fragment :-)

changelogs/fragments/2245-proxmox_fix_agent_string_handling.yml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - proxmox inventory - added handling of commas in KVM agent configuration string (https://github.com/ansible-collections/community.general/pull/2245).

plugins/inventory/proxmox.py

@@ -281,7 +281,9 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
                     parsed_value = [tag.strip() for tag in value.split(",")]
                     self.inventory.set_variable(name, parsed_key, parsed_value)
 
-                if config == 'agent' and int(value):
+                # The first field in the agent string tells you whether the agent is enabled
+                # the rest of the comma separated string is extra config for the agent
+                if config == 'agent' and int(value.split(',')[0]):
                     agent_iface_key = self.to_safe('%s%s' % (key, "_interfaces"))
                     agent_iface_value = self._get_agent_network_interfaces(node, vmid, vmtype)
                     if agent_iface_value:

tests/unit/plugins/inventory/test_proxmox.py

@@ -205,7 +205,7 @@ def get_json(url):
             "hotplug": "network,disk,usb",
             "scsi0": "local-lvm:vm-101-disk-0,size=8G",
             "net0": "virtio=ff:ff:ff:ff:ff:ff,bridge=vmbr0,firewall=1",
-            "agent": "1",
+            "agent": "1,fstrim_cloned_disks=1",
             "bios": "seabios",
             "ide0": "local-lvm:vm-101-cloudinit,media=cdrom,size=4M",
             "boot": "cdn",