From 0a8310b29f1f77c73146c38755a31ac48fffe625 Mon Sep 17 00:00:00 2001 From: Benjamin Wilson Date: Wed, 16 Dec 2015 16:39:42 -0500 Subject: [PATCH] Properly handle adding multiple bricks to volume --- lib/ansible/modules/extras/system/gluster_volume.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/ansible/modules/extras/system/gluster_volume.py b/lib/ansible/modules/extras/system/gluster_volume.py index 10d50c3437..6dd03892a3 100644 --- a/lib/ansible/modules/extras/system/gluster_volume.py +++ b/lib/ansible/modules/extras/system/gluster_volume.py @@ -289,8 +289,9 @@ def stop_volume(name): def set_volume_option(name, option, parameter): run_gluster([ 'volume', 'set', name, option, parameter ]) -def add_brick(name, brick, force): - args = [ 'volume', 'add-brick', name, brick ] +def add_bricks(name, new_bricks, force): + args = [ 'volume', 'add-brick', name ] + args.extend(new_bricks) if force: args.append('force') run_gluster(args) @@ -411,8 +412,8 @@ def main(): if brick not in all_bricks: removed_bricks.append(brick) - for brick in new_bricks: - add_brick(volume_name, brick, force) + if new_bricks: + add_bricks(volume_name, new_bricks, force) changed = True # handle quotas