From 0a28a0c8b0f18d7f09e08cf753a3d2d99e67a441 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Sat, 21 Nov 2020 17:25:49 +0100 Subject: [PATCH] ipa: Update non-secret fields matching '*pass*' with no_log=False (#1339) * ipa: Update non-secret fields matching '*pass*' with no_log=False * Add changelog fragment * Update changelogs/fragments/1339-ip-no_log-nonsecret.yml Co-authored-by: Felix Fontein Co-authored-by: Felix Fontein --- changelogs/fragments/1339-ip-no_log-nonsecret.yml | 3 +++ plugins/modules/identity/ipa/ipa_host.py | 2 +- plugins/modules/identity/ipa/ipa_user.py | 5 +++-- 3 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 changelogs/fragments/1339-ip-no_log-nonsecret.yml diff --git a/changelogs/fragments/1339-ip-no_log-nonsecret.yml b/changelogs/fragments/1339-ip-no_log-nonsecret.yml new file mode 100644 index 0000000000..b3619ad672 --- /dev/null +++ b/changelogs/fragments/1339-ip-no_log-nonsecret.yml @@ -0,0 +1,3 @@ +minor_changes: +- ipa_user - silence warning about non-secret ``krbpasswordexpiration`` and ``update_password`` options not having ``no_log`` set (https://github.com/ansible-collections/community.general/pull/1339). +- ipa_host - silence warning about non-secret ``random_password`` option not having ``no_log`` set (https://github.com/ansible-collections/community.general/pull/1339). diff --git a/plugins/modules/identity/ipa/ipa_host.py b/plugins/modules/identity/ipa/ipa_host.py index 1095dc203b..8e2957d115 100644 --- a/plugins/modules/identity/ipa/ipa_host.py +++ b/plugins/modules/identity/ipa/ipa_host.py @@ -284,7 +284,7 @@ def main(): mac_address=dict(type='list', aliases=['macaddress'], elements='str'), update_dns=dict(type='bool'), state=dict(type='str', default='present', choices=['present', 'absent', 'enabled', 'disabled']), - random_password=dict(type='bool'),) + random_password=dict(type='bool', no_log=False),) module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=True) diff --git a/plugins/modules/identity/ipa/ipa_user.py b/plugins/modules/identity/ipa/ipa_user.py index 814da2840c..fa7b3abbda 100644 --- a/plugins/modules/identity/ipa/ipa_user.py +++ b/plugins/modules/identity/ipa/ipa_user.py @@ -345,8 +345,9 @@ def main(): argument_spec.update(displayname=dict(type='str'), givenname=dict(type='str'), update_password=dict(type='str', default="always", - choices=['always', 'on_create']), - krbpasswordexpiration=dict(type='str'), + choices=['always', 'on_create'], + no_log=False), + krbpasswordexpiration=dict(type='str', no_log=False), loginshell=dict(type='str'), mail=dict(type='list', elements='str'), sn=dict(type='str'),