ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Made Linode inventory module much faster.

Browse source 
Listing no longer makes an API request for every node.
This commit is contained in:
Dan Slimmon 2013-07-25 16:58:15 +00:00
parent d1effecb2e
commit 09a2f23e8f
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
plugins/inventory/linode.py
View file

@ -98,6 +98,8 @@ class LinodeInventory(object):
self.inventory = {} self.inventory = {}
# Index of label to Linode ID # Index of label to Linode ID
self.index = {} self.index = {}
# Local cache of Datacenter objects populated by populate_datacenter_cache()
self._datacenter_cache = None
# Read settings and parse CLI arguments # Read settings and parse CLI arguments
self.read_settings() self.read_settings()
@ -162,7 +164,7 @@ class LinodeInventory(object):
def get_nodes(self): def get_nodes(self):
"""Makes an Linode API call to get the list of nodes.""" """Makes an Linode API call to get the list of nodes."""
try: try:
for node in Linode.search(): for node in Linode.search(status=Linode.STATUS_RUNNING):
self.add_node(node) self.add_node(node)
except api.linode_api.ApiError, e: except api.linode_api.ApiError, e:
print "Looks like Linode's API is down:" print "Looks like Linode's API is down:"
@ -180,9 +182,18 @@ class LinodeInventory(object):
print e print e
sys.exit(1) sys.exit(1)
def populate_datacenter_cache(self):
"""Creates self._datacenter_cache, containing all Datacenters indexed by ID."""
self._datacenter_cache = {}
dcs = Datacenter.search()
for dc in dcs:
self._datacenter_cache[dc.api_id] = dc
def get_datacenter_city(self, node): def get_datacenter_city(self, node):
"""Returns a the lowercase city name of the node's data center.""" """Returns a the lowercase city name of the node's data center."""
location = node.datacenter.location if self._datacenter_cache is None:
self.populate_datacenter_cache()
location = self._datacenter_cache[node.datacenter_id].location
location = location.lower() location = location.lower()
location = location.split(",")[0] location = location.split(",")[0]
return location return location
@ -190,10 +201,6 @@ class LinodeInventory(object):
def add_node(self, node): def add_node(self, node):
"""Adds an node to the inventory and index.""" """Adds an node to the inventory and index."""
# Only want running nodes
if not node.is_up():
return
dest = node.label dest = node.label
# Add to index # Add to index