From 00abaf6f8025b64437e64081aa5e98021a6d2867 Mon Sep 17 00:00:00 2001 From: Josh Kelley Date: Mon, 16 May 2022 02:45:12 -0400 Subject: [PATCH] Remove unsupported and unnecessary --no-emoji option (#4662) * Remove unsupported and unnecessary --no-emoji option `--no-emoji` causes errors in Yarn 2+ and should be unnecessary in Yarn 1.x; Yarn 1.x should only use emoji on supported interactive terminals. * Add changelog fragment * Update changelogs/fragments/4662-yarn-emoji.yml Co-authored-by: Felix Fontein * Update changelogs/fragments/4662-yarn-emoji.yml Co-authored-by: Felix Fontein Co-authored-by: Felix Fontein --- changelogs/fragments/4662-yarn-emoji.yml | 2 ++ plugins/modules/packaging/language/yarn.py | 5 +---- 2 files changed, 3 insertions(+), 4 deletions(-) create mode 100644 changelogs/fragments/4662-yarn-emoji.yml diff --git a/changelogs/fragments/4662-yarn-emoji.yml b/changelogs/fragments/4662-yarn-emoji.yml new file mode 100644 index 0000000000..696188dd9b --- /dev/null +++ b/changelogs/fragments/4662-yarn-emoji.yml @@ -0,0 +1,2 @@ +breaking_changes: + - yarn - remove unsupported and unnecessary ``--no-emoji`` flag (https://github.com/ansible-collections/community.general/pull/4662). diff --git a/plugins/modules/packaging/language/yarn.py b/plugins/modules/packaging/language/yarn.py index 7df043c279..6ea9db5d26 100644 --- a/plugins/modules/packaging/language/yarn.py +++ b/plugins/modules/packaging/language/yarn.py @@ -147,7 +147,7 @@ invocation: } } out: - description: Output generated from Yarn with emojis removed. + description: Output generated from Yarn. returned: always type: str sample: "yarn add v0.16.1[1/4] Resolving packages...[2/4] Fetching packages...[3/4] Linking dependencies...[4/4] @@ -205,9 +205,6 @@ class Yarn(object): cmd.append('--registry') cmd.append(self.registry) - # always run Yarn without emojis when called via Ansible - cmd.append('--no-emoji') - # If path is specified, cd into that path and run the command. cwd = None if self.path and not self.globally: