2017-01-11 21:03:26 +01:00
|
|
|
import pytest
|
2016-09-13 19:50:05 +02:00
|
|
|
|
2015-05-17 08:29:40 +02:00
|
|
|
from ansible.module_utils.database import (
|
|
|
|
pg_quote_identifier,
|
|
|
|
SQLParseError,
|
|
|
|
)
|
|
|
|
|
2017-01-11 21:03:26 +01:00
|
|
|
# These are all valid strings
|
|
|
|
# The results are based on interpreting the identifier as a table name
|
|
|
|
VALID = {
|
|
|
|
# User quoted
|
|
|
|
'"public.table"': '"public.table"',
|
|
|
|
'"public"."table"': '"public"."table"',
|
|
|
|
'"schema test"."table test"': '"schema test"."table test"',
|
|
|
|
|
|
|
|
# We quote part
|
|
|
|
'public.table': '"public"."table"',
|
|
|
|
'"public".table': '"public"."table"',
|
|
|
|
'public."table"': '"public"."table"',
|
|
|
|
'schema test.table test': '"schema test"."table test"',
|
|
|
|
'"schema test".table test': '"schema test"."table test"',
|
|
|
|
'schema test."table test"': '"schema test"."table test"',
|
|
|
|
|
|
|
|
# Embedded double quotes
|
|
|
|
'table "test"': '"table ""test"""',
|
|
|
|
'public."table ""test"""': '"public"."table ""test"""',
|
|
|
|
'public.table "test"': '"public"."table ""test"""',
|
|
|
|
'schema "test".table': '"schema ""test"""."table"',
|
|
|
|
'"schema ""test""".table': '"schema ""test"""."table"',
|
|
|
|
'"""wat"""."""test"""': '"""wat"""."""test"""',
|
|
|
|
# Sigh, handle these as well:
|
|
|
|
'"no end quote': '"""no end quote"',
|
|
|
|
'schema."table': '"schema"."""table"',
|
|
|
|
'"schema.table': '"""schema"."table"',
|
|
|
|
'schema."table.something': '"schema"."""table"."something"',
|
|
|
|
|
|
|
|
# Embedded dots
|
|
|
|
'"schema.test"."table.test"': '"schema.test"."table.test"',
|
|
|
|
'"schema.".table': '"schema."."table"',
|
|
|
|
'"schema."."table"': '"schema."."table"',
|
|
|
|
'schema.".table"': '"schema".".table"',
|
|
|
|
'"schema".".table"': '"schema".".table"',
|
|
|
|
'"schema.".".table"': '"schema.".".table"',
|
|
|
|
# These are valid but maybe not what the user intended
|
|
|
|
'."table"': '".""table"""',
|
|
|
|
'table.': '"table."',
|
|
|
|
}
|
|
|
|
|
|
|
|
INVALID = {
|
|
|
|
('test.too.many.dots', 'table'): 'PostgreSQL does not support table with more than 3 dots',
|
|
|
|
('"test.too".many.dots', 'database'): 'PostgreSQL does not support database with more than 1 dots',
|
|
|
|
('test.too."many.dots"', 'database'): 'PostgreSQL does not support database with more than 1 dots',
|
|
|
|
('"test"."too"."many"."dots"', 'database'): "PostgreSQL does not support database with more than 1 dots",
|
|
|
|
('"test"."too"."many"."dots"', 'schema'): "PostgreSQL does not support schema with more than 2 dots",
|
|
|
|
('"test"."too"."many"."dots"', 'table'): "PostgreSQL does not support table with more than 3 dots",
|
|
|
|
('"test"."too"."many"."dots"."for"."column"', 'column'): "PostgreSQL does not support column with more than 4 dots",
|
|
|
|
('"table "invalid" double quote"', 'table'): 'User escaped identifiers must escape extra quotes',
|
|
|
|
('"schema "invalid"""."table "invalid"', 'table'): 'User escaped identifiers must escape extra quotes',
|
|
|
|
('"schema."table"', 'table'): 'User escaped identifiers must escape extra quotes',
|
|
|
|
('"schema".', 'table'): 'Identifier name unspecified or unquoted trailing dot',
|
|
|
|
}
|
|
|
|
|
|
|
|
HOW_MANY_DOTS = (
|
|
|
|
('role', 'role', '"role"',
|
|
|
|
'PostgreSQL does not support role with more than 1 dots'),
|
|
|
|
('db', 'database', '"db"',
|
|
|
|
'PostgreSQL does not support database with more than 1 dots'),
|
|
|
|
('db.schema', 'schema', '"db"."schema"',
|
|
|
|
'PostgreSQL does not support schema with more than 2 dots'),
|
|
|
|
('db.schema.table', 'table', '"db"."schema"."table"',
|
|
|
|
'PostgreSQL does not support table with more than 3 dots'),
|
|
|
|
('db.schema.table.column', 'column', '"db"."schema"."table"."column"',
|
|
|
|
'PostgreSQL does not support column with more than 4 dots'),
|
|
|
|
)
|
|
|
|
|
|
|
|
VALID_QUOTES = ((test, VALID[test]) for test in VALID)
|
|
|
|
INVALID_QUOTES = ((test[0], test[1], INVALID[test]) for test in INVALID)
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize("identifier, quoted_identifier", VALID_QUOTES)
|
|
|
|
def test_valid_quotes(identifier, quoted_identifier):
|
|
|
|
assert pg_quote_identifier(identifier, 'table') == quoted_identifier
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize("identifier, id_type, msg", INVALID_QUOTES)
|
|
|
|
def test_invalid_quotes(identifier, id_type, msg):
|
|
|
|
with pytest.raises(SQLParseError) as ex:
|
|
|
|
pg_quote_identifier(identifier, id_type)
|
|
|
|
|
|
|
|
ex.match(msg)
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize("identifier, id_type, quoted_identifier, msg", HOW_MANY_DOTS)
|
|
|
|
def test_how_many_dots(identifier, id_type, quoted_identifier, msg):
|
|
|
|
assert pg_quote_identifier(identifier, id_type) == quoted_identifier
|
|
|
|
|
|
|
|
with pytest.raises(SQLParseError) as ex:
|
|
|
|
pg_quote_identifier('%s.more' % identifier, id_type)
|
2015-05-17 08:29:40 +02:00
|
|
|
|
2017-01-11 21:03:26 +01:00
|
|
|
ex.match(msg)
|