1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/tests/integration/targets/pkgng/tasks/freebsd.yml

552 lines
18 KiB
YAML
Raw Normal View History

pkgng: add basic integration tests (#3526) * pkgng: package reinstallations count as changed `upgrade_packages()` only looked for the string "Number of packages to be upgraded", but the `pkg upgrade` command also reports "Number of packages to be reinstalled". Reinstallation occurs when package metadata other than version changes (e.g. build options, single architecture to `*` architecture). In any other respect, though, a required reinstallation is the same as an upgrade. * pkgng: check_mode should count queued actions Writing tests caught a bug in PR #3393, which enabled installing more than one package per `pkg` execution. In converting the module's install/upgrade code to a queue structure, check_mode got broken because the count of actions performed was only updated in the `if not check_mode` block that invokes `pkg`. This two-line change counts the number of actions in the queue when check mode is enabled. * pkgng: add basic integration tests Test installing a package Test installing a package into a jail * pkgng: test with zsh not bash package Had been using bash package, because it's not likely to disappear from the package repository any time soon. Turns out that bash is already installed on the Ansible community.general FreeBSD CI VM image, which makes the test fail. Zsh probably isn't going away any time soon, either, and likely won't be installed on the CI image. * pkgng: remove redundant test for docker container These tests should be skip/docker, but the test playbook also redundantly checked whether it was running in a docker container. Checking whether `ansible_facts.distribution` is `FreeBSD` is really sufficient to be sure whether the test is running in an environment that supports the `pkgng` module. * pkgng: add state=absent test Also renumber `jail=...` test to make diffs less noisy when adding more non-jailed tests. * pkgng: add state=latest idemptency test Add test between state=present and state=absent that ensures state=latest runs successfully on an already up-to-date package with changed=false. * pkgng: add state=latest test Including small filesize out-of-date package from FreeBSD 11 package repository, because FreeBSD 11 is currently EOL. This test might fail at some point in the future if the pkg utility in a FreeBSD version > 14 makes breaking changes that prevents it from installing older package formats. If that occurs, the fix is to replace `files/freebsd-release-manifests-20210413__FreeBSD_11.pkg` with the version of freebsd-release-manifests from the oldest non-breaking release of FreeBSD, and update the references to it in tasks/main.yml accordingly. * pkgng: use hand-generated test package Instead of relying on a broken-ish installation of an older package from FreeBSD 11, hand-generate a package named `zsh` with no contents and a version number of `0`. It can be installed on any architecture and any revision of FreeBSD sucessfully, and it will always be eligible for upgrade. * pkgng: CI seems to dislike plus-signs in filenames * pkgng: refactor renaming test package manifests refactored to make intent of adding '+' sign clearer * pkgng: refactor upgraded pattern matching Implement russoz's suggestion to put all variants in the pattern. * pkgng: add cached=yes test Changed idempotency test, because this covers both. * pkgng: test pkg works on any FreeBSD version Removing `ansible_distribution_version`, because the test out-of-date zsh package should install on any FreeBSD version. * pkgng: move FreeBSD tasks to imported file Refactoring tests for more reuse and easier readability. * pkgng: refactor tests for task reuse Several tests need to install an out-of-date package to test whether upgrades occur successfully, so this commit refactors out the generation of the test package. Also, factor out things like the name and path of the test package so that is more maintainable should the target test package (currently `zsh`) ever need to change. * pkgng: test install multiple packages Multiple packages should install with a single invocation of the `pkg` utility. * pkgng: handle space- and comma-separated lists The module expects a list of strings in the `name` parameter, but long-standing documentation showed space- and comma-delimited lists as a valid way of telling the module to act on multiple packages. Passing these lists through to the `pkg` command can have unexpected side-effects of upgrading packages when `state=present` rather than `state=latest` and could result in the module reporting the wrong number of packages for each action performed. * pkgng: test state=latest for mixed install/upgrade Test that a list of packages given, one not installed and one installed but out-of-date are handled correctly. * pkgng: use YAML lists for multiple packages I had been following the documentation examples, and specifiying multiple packages on one line. The right way to do it is with YAML list syntax. * pkgng: add test for autoremove=yes Install package with known dependencies, then remove it and ask autoremove to run. * pkgng: test autoremove=yes only on FreeBSD > 12 The CI test runner on FreeBSD 12.0 times out when downloading large packages. * pkgng: test jail creation logging less verbose `ezjail-admin` had been spewing every filename copied into the jail onto stderr, making the `ansible-test -v` logs hard to scroll through. Changed it so that ezjail output only shows up in the ansible task logs if `ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin` output is always logged to `/tmp/ezjail.log`. * pkgng: pass tests when package dependencies change Tests that install packages with dependencies were failing when those dependencies were not already installed, because the count of installed packages was greater than the count of requested to be installed packages. This change checks for a count of installed packages that is greater than or equal to the count of requested to be installed packages. Example: - Test installs packages `zsh` and `fish` - `fish` has a dependency on `pcre2` - `pkg` reports `Number of packages to be installed: 3` * pkgng: test annotation for single package Add/modify/remove annotation for a single package * pkgng: fix annotation operations Annotation has been broken at least since the migration to collections. There are some breaking typos and function argument omissions in the code with nothing in `git blame` but "Initial commit". New integration tests uncovered this breakage. Works now. * pkgng: test multiple annotations Test multiple annotations specified both in new (YAML list) syntax and old (comma-delimited) syntax. Rename some annotation test tags from the single-annotation tests to make sure that single and multiple annotation tests don't collide. * pkgng: test invalid annotate strings Ensure that some likely to occur, invalid strings given to the annotate module parameter 1. fail, 2. do not cause an exception, and 3. do not create any actual annotations on packages. * pkgng: fix check_mode for annotate Actions specified in the `annotate` parameter would always be performed, even if `check_mode=yes`. This commit fixes `check_mode` for the annotation functions and adds integration tests to ensure that check mode is honored in the future. * pkgng: call module.run_command with list Instead of calling `run_command` with a formatted string, call it with a list to maintain safer argument separation. Also, introduce a wrapper for `run_command`, `run_pkgng`, which manages the process environment and some common command line switches, based upon the module parameters. Introduced in this commit, also pass annotation values to `pkg annotate` via stdin, which is safer with long values than putting them in argv. * pkgng: update documentation to match annotate type Missed updating the documentation to match the change of the annotate parameter from comma-separated string to list of strings. * pkgng: fix syntax for Python 2 Seems *args, **kwargs have to be the last two arguments in Python 2 syntax. CI sanity tests were failing. * pkgng: oops, pkgsite should be from closure I put `pkgsite` as a keyword argument to `run_pkgng()', which wasn't correct at all and resulted it in capturing the second positional argument given by any caller. `pkgsite` should have been `p["pkgsite"]`, coming from the closure environment of `main()`. * pkgng: Fix changelog fragment quote formatting Co-authored-by: Felix Fontein <felix@fontein.de> * pkgng: add test prepare task Make sure test environment does not contain the test package. * pkgng: make integration test package more flexible Make integration test package building template-based, so more flexible if in the future the name of the test package, currently `zsh`, must change. * pkgng: convert generator to list for 2.9 Ansible 2.9 can't count items from a generator, so convert `select` filter output via `list` before passing to `count`. * pkgng: Ansible 2.9 has no "false" Jinja2 test Apparently Ansible 2.9 doesn't have the "false" test in Jinja2 contexts. Switching to use `rejectattr(...)` instead of `selectattr(..., "false")`. * pkgng: test pkgsite parameter * pkgng: add tests for chroot and rootdir params Refactor install tasks into an include file so they can be reused and tested with various parameters. * pkgng: clean up test package creation Make pkg json manifest more readable. Create package using FreeBSD's `pkg create` instead of manually using tar. This change also simplifies the manifest to a single file for the integration test role. * pkgng: fix #3428; install from local file Fixes a bug in which the module reported failure when installing from a local (to the target host) file path. Fixes #3428 * pkgng: changelog fragment formatting issue * pkgng: check for all test package extensions pkg recently changed file extensions, so for the tests to work on multiple recent versions of FreeBSD, we must check for `pkg create` output with varying filename. * Revert "pkgng: fix #3428; install from local file" As the module has invoked pkg with the `-g` flag for at least 7 years, I'm not sure when it was possible to install packages from files on the target host filesystem, because pkg rejects file paths when the `--glob` flag is enabled. I considered doing a rework of the pkg invocation to enable good support for installing from local files, but it looks like more of a job than for this PR. This reverts commit 5f94eac41ff040a79d4d00d2f723a9b3a148418e. * pkgng: Add minor_changes fragment for #3526 Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de>
2021-10-22 07:32:35 +02:00
---
# Copyright (c) Ansible Project
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
# SPDX-License-Identifier: GPL-3.0-or-later
pkgng: add basic integration tests (#3526) * pkgng: package reinstallations count as changed `upgrade_packages()` only looked for the string "Number of packages to be upgraded", but the `pkg upgrade` command also reports "Number of packages to be reinstalled". Reinstallation occurs when package metadata other than version changes (e.g. build options, single architecture to `*` architecture). In any other respect, though, a required reinstallation is the same as an upgrade. * pkgng: check_mode should count queued actions Writing tests caught a bug in PR #3393, which enabled installing more than one package per `pkg` execution. In converting the module's install/upgrade code to a queue structure, check_mode got broken because the count of actions performed was only updated in the `if not check_mode` block that invokes `pkg`. This two-line change counts the number of actions in the queue when check mode is enabled. * pkgng: add basic integration tests Test installing a package Test installing a package into a jail * pkgng: test with zsh not bash package Had been using bash package, because it's not likely to disappear from the package repository any time soon. Turns out that bash is already installed on the Ansible community.general FreeBSD CI VM image, which makes the test fail. Zsh probably isn't going away any time soon, either, and likely won't be installed on the CI image. * pkgng: remove redundant test for docker container These tests should be skip/docker, but the test playbook also redundantly checked whether it was running in a docker container. Checking whether `ansible_facts.distribution` is `FreeBSD` is really sufficient to be sure whether the test is running in an environment that supports the `pkgng` module. * pkgng: add state=absent test Also renumber `jail=...` test to make diffs less noisy when adding more non-jailed tests. * pkgng: add state=latest idemptency test Add test between state=present and state=absent that ensures state=latest runs successfully on an already up-to-date package with changed=false. * pkgng: add state=latest test Including small filesize out-of-date package from FreeBSD 11 package repository, because FreeBSD 11 is currently EOL. This test might fail at some point in the future if the pkg utility in a FreeBSD version > 14 makes breaking changes that prevents it from installing older package formats. If that occurs, the fix is to replace `files/freebsd-release-manifests-20210413__FreeBSD_11.pkg` with the version of freebsd-release-manifests from the oldest non-breaking release of FreeBSD, and update the references to it in tasks/main.yml accordingly. * pkgng: use hand-generated test package Instead of relying on a broken-ish installation of an older package from FreeBSD 11, hand-generate a package named `zsh` with no contents and a version number of `0`. It can be installed on any architecture and any revision of FreeBSD sucessfully, and it will always be eligible for upgrade. * pkgng: CI seems to dislike plus-signs in filenames * pkgng: refactor renaming test package manifests refactored to make intent of adding '+' sign clearer * pkgng: refactor upgraded pattern matching Implement russoz's suggestion to put all variants in the pattern. * pkgng: add cached=yes test Changed idempotency test, because this covers both. * pkgng: test pkg works on any FreeBSD version Removing `ansible_distribution_version`, because the test out-of-date zsh package should install on any FreeBSD version. * pkgng: move FreeBSD tasks to imported file Refactoring tests for more reuse and easier readability. * pkgng: refactor tests for task reuse Several tests need to install an out-of-date package to test whether upgrades occur successfully, so this commit refactors out the generation of the test package. Also, factor out things like the name and path of the test package so that is more maintainable should the target test package (currently `zsh`) ever need to change. * pkgng: test install multiple packages Multiple packages should install with a single invocation of the `pkg` utility. * pkgng: handle space- and comma-separated lists The module expects a list of strings in the `name` parameter, but long-standing documentation showed space- and comma-delimited lists as a valid way of telling the module to act on multiple packages. Passing these lists through to the `pkg` command can have unexpected side-effects of upgrading packages when `state=present` rather than `state=latest` and could result in the module reporting the wrong number of packages for each action performed. * pkgng: test state=latest for mixed install/upgrade Test that a list of packages given, one not installed and one installed but out-of-date are handled correctly. * pkgng: use YAML lists for multiple packages I had been following the documentation examples, and specifiying multiple packages on one line. The right way to do it is with YAML list syntax. * pkgng: add test for autoremove=yes Install package with known dependencies, then remove it and ask autoremove to run. * pkgng: test autoremove=yes only on FreeBSD > 12 The CI test runner on FreeBSD 12.0 times out when downloading large packages. * pkgng: test jail creation logging less verbose `ezjail-admin` had been spewing every filename copied into the jail onto stderr, making the `ansible-test -v` logs hard to scroll through. Changed it so that ezjail output only shows up in the ansible task logs if `ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin` output is always logged to `/tmp/ezjail.log`. * pkgng: pass tests when package dependencies change Tests that install packages with dependencies were failing when those dependencies were not already installed, because the count of installed packages was greater than the count of requested to be installed packages. This change checks for a count of installed packages that is greater than or equal to the count of requested to be installed packages. Example: - Test installs packages `zsh` and `fish` - `fish` has a dependency on `pcre2` - `pkg` reports `Number of packages to be installed: 3` * pkgng: test annotation for single package Add/modify/remove annotation for a single package * pkgng: fix annotation operations Annotation has been broken at least since the migration to collections. There are some breaking typos and function argument omissions in the code with nothing in `git blame` but "Initial commit". New integration tests uncovered this breakage. Works now. * pkgng: test multiple annotations Test multiple annotations specified both in new (YAML list) syntax and old (comma-delimited) syntax. Rename some annotation test tags from the single-annotation tests to make sure that single and multiple annotation tests don't collide. * pkgng: test invalid annotate strings Ensure that some likely to occur, invalid strings given to the annotate module parameter 1. fail, 2. do not cause an exception, and 3. do not create any actual annotations on packages. * pkgng: fix check_mode for annotate Actions specified in the `annotate` parameter would always be performed, even if `check_mode=yes`. This commit fixes `check_mode` for the annotation functions and adds integration tests to ensure that check mode is honored in the future. * pkgng: call module.run_command with list Instead of calling `run_command` with a formatted string, call it with a list to maintain safer argument separation. Also, introduce a wrapper for `run_command`, `run_pkgng`, which manages the process environment and some common command line switches, based upon the module parameters. Introduced in this commit, also pass annotation values to `pkg annotate` via stdin, which is safer with long values than putting them in argv. * pkgng: update documentation to match annotate type Missed updating the documentation to match the change of the annotate parameter from comma-separated string to list of strings. * pkgng: fix syntax for Python 2 Seems *args, **kwargs have to be the last two arguments in Python 2 syntax. CI sanity tests were failing. * pkgng: oops, pkgsite should be from closure I put `pkgsite` as a keyword argument to `run_pkgng()', which wasn't correct at all and resulted it in capturing the second positional argument given by any caller. `pkgsite` should have been `p["pkgsite"]`, coming from the closure environment of `main()`. * pkgng: Fix changelog fragment quote formatting Co-authored-by: Felix Fontein <felix@fontein.de> * pkgng: add test prepare task Make sure test environment does not contain the test package. * pkgng: make integration test package more flexible Make integration test package building template-based, so more flexible if in the future the name of the test package, currently `zsh`, must change. * pkgng: convert generator to list for 2.9 Ansible 2.9 can't count items from a generator, so convert `select` filter output via `list` before passing to `count`. * pkgng: Ansible 2.9 has no "false" Jinja2 test Apparently Ansible 2.9 doesn't have the "false" test in Jinja2 contexts. Switching to use `rejectattr(...)` instead of `selectattr(..., "false")`. * pkgng: test pkgsite parameter * pkgng: add tests for chroot and rootdir params Refactor install tasks into an include file so they can be reused and tested with various parameters. * pkgng: clean up test package creation Make pkg json manifest more readable. Create package using FreeBSD's `pkg create` instead of manually using tar. This change also simplifies the manifest to a single file for the integration test role. * pkgng: fix #3428; install from local file Fixes a bug in which the module reported failure when installing from a local (to the target host) file path. Fixes #3428 * pkgng: changelog fragment formatting issue * pkgng: check for all test package extensions pkg recently changed file extensions, so for the tests to work on multiple recent versions of FreeBSD, we must check for `pkg create` output with varying filename. * Revert "pkgng: fix #3428; install from local file" As the module has invoked pkg with the `-g` flag for at least 7 years, I'm not sure when it was possible to install packages from files on the target host filesystem, because pkg rejects file paths when the `--glob` flag is enabled. I considered doing a rework of the pkg invocation to enable good support for installing from local files, but it looks like more of a job than for this PR. This reverts commit 5f94eac41ff040a79d4d00d2f723a9b3a148418e. * pkgng: Add minor_changes fragment for #3526 Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de>
2021-10-22 07:32:35 +02:00
##
## pkgng - prepare test environment
##
- name: Remove test package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: absent
##
## pkgng - example - state=present for single package
##
- name: 'state=present for single package'
include_tasks: install_single_package.yml
##
## pkgng - example - state=latest for already up-to-date package
##
- name: Upgrade package (idempotent)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: latest
register: pkgng_example2
- name: Ensure pkgng does not upgrade up-to-date package
assert:
that:
- not pkgng_example2.changed
##
## pkgng - example - state=absent for single package
##
- name: Verify package sentinel file is present
stat:
path: '{{ pkgng_test_pkg_sentinelfile_path }}'
get_attributes: no
get_checksum: no
get_mime: no
register: pkgng_example3_stat_before
- name: Install package (checkmode)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
check_mode: yes
register: pkgng_example3_checkmode
- name: Remove package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: absent
register: pkgng_example3
- name: Remove package (idempotent)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: absent
register: pkgng_example3_idempotent
- name: Verify package sentinel file is not present
stat:
path: '{{ pkgng_test_pkg_sentinelfile_path }}'
get_attributes: no
get_checksum: no
get_mime: no
register: pkgng_example3_stat_after
- name: Ensure pkgng installs package correctly
assert:
that:
- pkgng_example3_stat_before.stat.exists
- pkgng_example3_stat_before.stat.executable
- not pkgng_example3_checkmode.changed
- pkgng_example3.changed
- not pkgng_example3_idempotent.changed
- not pkgng_example3_stat_after.stat.exists
##
## pkgng - example - state=latest for out-of-date package
##
- name: Install intentionally out-of-date package and upgrade it
#
# NOTE: The out-of-date package provided is a minimal,
# no-contents test package that declares {{ pkgng_test_pkg_name }} with
# a version of 0, so it should always be upgraded.
#
# This test might fail at some point in the
# future if the FreeBSD package format receives
# breaking changes that prevent pkg from installing
# older package formats.
#
block:
- name: Create out-of-date test package
import_tasks: create-outofdate-pkg.yml
- name: Install out-of-date test package
command: 'pkg add {{ pkgng_test_outofdate_pkg_path }}'
register: pkgng_example4_prepare
- name: Check for any available package upgrades (checkmode)
pkgng:
name: '*'
state: latest
check_mode: yes
register: pkgng_example4_wildcard_checkmode
- name: Check for available package upgrade (checkmode)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: latest
check_mode: yes
register: pkgng_example4_checkmode
- name: Upgrade out-of-date package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: latest
register: pkgng_example4
- name: Upgrade out-of-date package (idempotent)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: latest
register: pkgng_example4_idempotent
- name: Remove test out-of-date package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: absent
- name: Ensure pkgng upgrades package correctly
assert:
that:
- not pkgng_example4_prepare.failed
- pkgng_example4_wildcard_checkmode.changed
- pkgng_example4_checkmode.changed
- pkgng_example4.changed
- not pkgng_example4_idempotent.changed
##
## pkgng - example - state=latest for out-of-date package without privileges
##
- name: Install intentionally out-of-date package and try to upgrade it with unprivileged user
block:
- ansible.builtin.user:
name: powerless
shell: /bin/bash
- name: Create out-of-date test package
import_tasks: create-outofdate-pkg.yml
- name: Install out-of-date test package
command: 'pkg add {{ pkgng_test_outofdate_pkg_path }}'
register: pkgng_example4_nopower_prepare
- name: Check for any available package upgrades with unprivileged user
become: true
become_user: powerless
pkgng:
name: '*'
state: latest
register: pkgng_example4_nopower_wildcard
ignore_errors: true
- name: Remove test out-of-date package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: absent
- name: Ensure pkgng upgrades package correctly
assert:
that:
- not pkgng_example4_nopower_prepare.failed
- pkgng_example4_nopower_wildcard.failed
pkgng: add basic integration tests (#3526) * pkgng: package reinstallations count as changed `upgrade_packages()` only looked for the string "Number of packages to be upgraded", but the `pkg upgrade` command also reports "Number of packages to be reinstalled". Reinstallation occurs when package metadata other than version changes (e.g. build options, single architecture to `*` architecture). In any other respect, though, a required reinstallation is the same as an upgrade. * pkgng: check_mode should count queued actions Writing tests caught a bug in PR #3393, which enabled installing more than one package per `pkg` execution. In converting the module's install/upgrade code to a queue structure, check_mode got broken because the count of actions performed was only updated in the `if not check_mode` block that invokes `pkg`. This two-line change counts the number of actions in the queue when check mode is enabled. * pkgng: add basic integration tests Test installing a package Test installing a package into a jail * pkgng: test with zsh not bash package Had been using bash package, because it's not likely to disappear from the package repository any time soon. Turns out that bash is already installed on the Ansible community.general FreeBSD CI VM image, which makes the test fail. Zsh probably isn't going away any time soon, either, and likely won't be installed on the CI image. * pkgng: remove redundant test for docker container These tests should be skip/docker, but the test playbook also redundantly checked whether it was running in a docker container. Checking whether `ansible_facts.distribution` is `FreeBSD` is really sufficient to be sure whether the test is running in an environment that supports the `pkgng` module. * pkgng: add state=absent test Also renumber `jail=...` test to make diffs less noisy when adding more non-jailed tests. * pkgng: add state=latest idemptency test Add test between state=present and state=absent that ensures state=latest runs successfully on an already up-to-date package with changed=false. * pkgng: add state=latest test Including small filesize out-of-date package from FreeBSD 11 package repository, because FreeBSD 11 is currently EOL. This test might fail at some point in the future if the pkg utility in a FreeBSD version > 14 makes breaking changes that prevents it from installing older package formats. If that occurs, the fix is to replace `files/freebsd-release-manifests-20210413__FreeBSD_11.pkg` with the version of freebsd-release-manifests from the oldest non-breaking release of FreeBSD, and update the references to it in tasks/main.yml accordingly. * pkgng: use hand-generated test package Instead of relying on a broken-ish installation of an older package from FreeBSD 11, hand-generate a package named `zsh` with no contents and a version number of `0`. It can be installed on any architecture and any revision of FreeBSD sucessfully, and it will always be eligible for upgrade. * pkgng: CI seems to dislike plus-signs in filenames * pkgng: refactor renaming test package manifests refactored to make intent of adding '+' sign clearer * pkgng: refactor upgraded pattern matching Implement russoz's suggestion to put all variants in the pattern. * pkgng: add cached=yes test Changed idempotency test, because this covers both. * pkgng: test pkg works on any FreeBSD version Removing `ansible_distribution_version`, because the test out-of-date zsh package should install on any FreeBSD version. * pkgng: move FreeBSD tasks to imported file Refactoring tests for more reuse and easier readability. * pkgng: refactor tests for task reuse Several tests need to install an out-of-date package to test whether upgrades occur successfully, so this commit refactors out the generation of the test package. Also, factor out things like the name and path of the test package so that is more maintainable should the target test package (currently `zsh`) ever need to change. * pkgng: test install multiple packages Multiple packages should install with a single invocation of the `pkg` utility. * pkgng: handle space- and comma-separated lists The module expects a list of strings in the `name` parameter, but long-standing documentation showed space- and comma-delimited lists as a valid way of telling the module to act on multiple packages. Passing these lists through to the `pkg` command can have unexpected side-effects of upgrading packages when `state=present` rather than `state=latest` and could result in the module reporting the wrong number of packages for each action performed. * pkgng: test state=latest for mixed install/upgrade Test that a list of packages given, one not installed and one installed but out-of-date are handled correctly. * pkgng: use YAML lists for multiple packages I had been following the documentation examples, and specifiying multiple packages on one line. The right way to do it is with YAML list syntax. * pkgng: add test for autoremove=yes Install package with known dependencies, then remove it and ask autoremove to run. * pkgng: test autoremove=yes only on FreeBSD > 12 The CI test runner on FreeBSD 12.0 times out when downloading large packages. * pkgng: test jail creation logging less verbose `ezjail-admin` had been spewing every filename copied into the jail onto stderr, making the `ansible-test -v` logs hard to scroll through. Changed it so that ezjail output only shows up in the ansible task logs if `ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin` output is always logged to `/tmp/ezjail.log`. * pkgng: pass tests when package dependencies change Tests that install packages with dependencies were failing when those dependencies were not already installed, because the count of installed packages was greater than the count of requested to be installed packages. This change checks for a count of installed packages that is greater than or equal to the count of requested to be installed packages. Example: - Test installs packages `zsh` and `fish` - `fish` has a dependency on `pcre2` - `pkg` reports `Number of packages to be installed: 3` * pkgng: test annotation for single package Add/modify/remove annotation for a single package * pkgng: fix annotation operations Annotation has been broken at least since the migration to collections. There are some breaking typos and function argument omissions in the code with nothing in `git blame` but "Initial commit". New integration tests uncovered this breakage. Works now. * pkgng: test multiple annotations Test multiple annotations specified both in new (YAML list) syntax and old (comma-delimited) syntax. Rename some annotation test tags from the single-annotation tests to make sure that single and multiple annotation tests don't collide. * pkgng: test invalid annotate strings Ensure that some likely to occur, invalid strings given to the annotate module parameter 1. fail, 2. do not cause an exception, and 3. do not create any actual annotations on packages. * pkgng: fix check_mode for annotate Actions specified in the `annotate` parameter would always be performed, even if `check_mode=yes`. This commit fixes `check_mode` for the annotation functions and adds integration tests to ensure that check mode is honored in the future. * pkgng: call module.run_command with list Instead of calling `run_command` with a formatted string, call it with a list to maintain safer argument separation. Also, introduce a wrapper for `run_command`, `run_pkgng`, which manages the process environment and some common command line switches, based upon the module parameters. Introduced in this commit, also pass annotation values to `pkg annotate` via stdin, which is safer with long values than putting them in argv. * pkgng: update documentation to match annotate type Missed updating the documentation to match the change of the annotate parameter from comma-separated string to list of strings. * pkgng: fix syntax for Python 2 Seems *args, **kwargs have to be the last two arguments in Python 2 syntax. CI sanity tests were failing. * pkgng: oops, pkgsite should be from closure I put `pkgsite` as a keyword argument to `run_pkgng()', which wasn't correct at all and resulted it in capturing the second positional argument given by any caller. `pkgsite` should have been `p["pkgsite"]`, coming from the closure environment of `main()`. * pkgng: Fix changelog fragment quote formatting Co-authored-by: Felix Fontein <felix@fontein.de> * pkgng: add test prepare task Make sure test environment does not contain the test package. * pkgng: make integration test package more flexible Make integration test package building template-based, so more flexible if in the future the name of the test package, currently `zsh`, must change. * pkgng: convert generator to list for 2.9 Ansible 2.9 can't count items from a generator, so convert `select` filter output via `list` before passing to `count`. * pkgng: Ansible 2.9 has no "false" Jinja2 test Apparently Ansible 2.9 doesn't have the "false" test in Jinja2 contexts. Switching to use `rejectattr(...)` instead of `selectattr(..., "false")`. * pkgng: test pkgsite parameter * pkgng: add tests for chroot and rootdir params Refactor install tasks into an include file so they can be reused and tested with various parameters. * pkgng: clean up test package creation Make pkg json manifest more readable. Create package using FreeBSD's `pkg create` instead of manually using tar. This change also simplifies the manifest to a single file for the integration test role. * pkgng: fix #3428; install from local file Fixes a bug in which the module reported failure when installing from a local (to the target host) file path. Fixes #3428 * pkgng: changelog fragment formatting issue * pkgng: check for all test package extensions pkg recently changed file extensions, so for the tests to work on multiple recent versions of FreeBSD, we must check for `pkg create` output with varying filename. * Revert "pkgng: fix #3428; install from local file" As the module has invoked pkg with the `-g` flag for at least 7 years, I'm not sure when it was possible to install packages from files on the target host filesystem, because pkg rejects file paths when the `--glob` flag is enabled. I considered doing a rework of the pkg invocation to enable good support for installing from local files, but it looks like more of a job than for this PR. This reverts commit 5f94eac41ff040a79d4d00d2f723a9b3a148418e. * pkgng: Add minor_changes fragment for #3526 Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de>
2021-10-22 07:32:35 +02:00
##
## pkgng - example - Install multiple packages in one command
##
- name: Remove test package (checkmode)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: absent
check_mode: yes
register: pkgng_example5_prepare
- name: Install three packages
pkgng:
name:
- '{{ pkgng_test_pkg_name }}'
- fish
- busybox
register: pkgng_example5
- name: Remove three packages
pkgng:
name:
- '{{ pkgng_test_pkg_name }}'
- fish
- busybox
state: absent
register: pkgng_example5_cleanup
- name: Ensure pkgng installs multiple packages with one command
assert:
that:
- not pkgng_example5_prepare.changed
- pkgng_example5.changed
- '(pkgng_example5.stdout | regex_search("^Number of packages to be installed: (\d+)", "\\1", multiline=True) | first | int) >= 3'
- '(pkgng_example5.stdout | regex_findall("^Number of packages to be", multiline=True) | count) == 1'
- pkgng_example5_cleanup.changed
##
## pkgng - example - state=latest multiple packages, some already installed
##
- name: Remove test package (checkmode)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
state: absent
check_mode: yes
register: pkgng_example6_check
- name: Create out-of-date test package
import_tasks: create-outofdate-pkg.yml
- name: Install out-of-date test package
command: 'pkg add {{ pkgng_test_outofdate_pkg_path }}'
register: pkgng_example6_prepare
- name: Upgrade and/or install two packages
pkgng:
name:
- '{{ pkgng_test_pkg_name }}'
- fish
state: latest
register: pkgng_example6
- name: Remove two packages
pkgng:
name:
- '{{ pkgng_test_pkg_name }}'
- fish
state: absent
register: pkgng_example6_cleanup
- name: Ensure pkgng installs multiple packages with one command
assert:
that:
- not pkgng_example6_check.changed
- not pkgng_example6_prepare.failed
- pkgng_example6.changed
- '(pkgng_example6.stdout | regex_search("^Number of packages to be installed: (\d+)", "\\1", multiline=True) | first | int) >= 1'
- '(pkgng_example6.stdout | regex_search("^Number of packages to be upgraded: (\d+)", "\\1", multiline=True) | first | int) >= 1'
# Checking that "will be affected" occurs twice in the output ensures
# that the module runs two separate commands for install and upgrade,
# as the pkg command only outputs the string once per invocation.
- '(pkgng_example6.stdout | regex_findall("will be affected", multiline=True) | count) == 2'
- pkgng_example6_cleanup.changed
##
## pkgng - example - autoremove=yes
##
- name: "Test autoremove=yes"
#
# NOTE: FreeBSD 12.0 test runner receives a "connection reset by peer" after ~20% downloaded so we are
# only running this on 12.1 or higher
#
when: ansible_distribution_version is version('12.01', '>=')
block:
- name: Install GNU autotools
pkgng:
name: autotools
state: latest
register: pkgng_example7_prepare_install
- name: Remove GNU autotools and run pkg autoremove
pkgng:
name: autotools
state: absent
autoremove: yes
register: pkgng_example7
- name: Check if autoremove uninstalled known autotools dependencies
pkgng:
name:
- autoconf
- automake
- libtool
state: absent
check_mode: yes
register: pkgng_example7_cleanup
- name: Ensure pkgng autoremove works correctly
assert:
that:
- pkgng_example7_prepare_install is changed
pkgng: add basic integration tests (#3526) * pkgng: package reinstallations count as changed `upgrade_packages()` only looked for the string "Number of packages to be upgraded", but the `pkg upgrade` command also reports "Number of packages to be reinstalled". Reinstallation occurs when package metadata other than version changes (e.g. build options, single architecture to `*` architecture). In any other respect, though, a required reinstallation is the same as an upgrade. * pkgng: check_mode should count queued actions Writing tests caught a bug in PR #3393, which enabled installing more than one package per `pkg` execution. In converting the module's install/upgrade code to a queue structure, check_mode got broken because the count of actions performed was only updated in the `if not check_mode` block that invokes `pkg`. This two-line change counts the number of actions in the queue when check mode is enabled. * pkgng: add basic integration tests Test installing a package Test installing a package into a jail * pkgng: test with zsh not bash package Had been using bash package, because it's not likely to disappear from the package repository any time soon. Turns out that bash is already installed on the Ansible community.general FreeBSD CI VM image, which makes the test fail. Zsh probably isn't going away any time soon, either, and likely won't be installed on the CI image. * pkgng: remove redundant test for docker container These tests should be skip/docker, but the test playbook also redundantly checked whether it was running in a docker container. Checking whether `ansible_facts.distribution` is `FreeBSD` is really sufficient to be sure whether the test is running in an environment that supports the `pkgng` module. * pkgng: add state=absent test Also renumber `jail=...` test to make diffs less noisy when adding more non-jailed tests. * pkgng: add state=latest idemptency test Add test between state=present and state=absent that ensures state=latest runs successfully on an already up-to-date package with changed=false. * pkgng: add state=latest test Including small filesize out-of-date package from FreeBSD 11 package repository, because FreeBSD 11 is currently EOL. This test might fail at some point in the future if the pkg utility in a FreeBSD version > 14 makes breaking changes that prevents it from installing older package formats. If that occurs, the fix is to replace `files/freebsd-release-manifests-20210413__FreeBSD_11.pkg` with the version of freebsd-release-manifests from the oldest non-breaking release of FreeBSD, and update the references to it in tasks/main.yml accordingly. * pkgng: use hand-generated test package Instead of relying on a broken-ish installation of an older package from FreeBSD 11, hand-generate a package named `zsh` with no contents and a version number of `0`. It can be installed on any architecture and any revision of FreeBSD sucessfully, and it will always be eligible for upgrade. * pkgng: CI seems to dislike plus-signs in filenames * pkgng: refactor renaming test package manifests refactored to make intent of adding '+' sign clearer * pkgng: refactor upgraded pattern matching Implement russoz's suggestion to put all variants in the pattern. * pkgng: add cached=yes test Changed idempotency test, because this covers both. * pkgng: test pkg works on any FreeBSD version Removing `ansible_distribution_version`, because the test out-of-date zsh package should install on any FreeBSD version. * pkgng: move FreeBSD tasks to imported file Refactoring tests for more reuse and easier readability. * pkgng: refactor tests for task reuse Several tests need to install an out-of-date package to test whether upgrades occur successfully, so this commit refactors out the generation of the test package. Also, factor out things like the name and path of the test package so that is more maintainable should the target test package (currently `zsh`) ever need to change. * pkgng: test install multiple packages Multiple packages should install with a single invocation of the `pkg` utility. * pkgng: handle space- and comma-separated lists The module expects a list of strings in the `name` parameter, but long-standing documentation showed space- and comma-delimited lists as a valid way of telling the module to act on multiple packages. Passing these lists through to the `pkg` command can have unexpected side-effects of upgrading packages when `state=present` rather than `state=latest` and could result in the module reporting the wrong number of packages for each action performed. * pkgng: test state=latest for mixed install/upgrade Test that a list of packages given, one not installed and one installed but out-of-date are handled correctly. * pkgng: use YAML lists for multiple packages I had been following the documentation examples, and specifiying multiple packages on one line. The right way to do it is with YAML list syntax. * pkgng: add test for autoremove=yes Install package with known dependencies, then remove it and ask autoremove to run. * pkgng: test autoremove=yes only on FreeBSD > 12 The CI test runner on FreeBSD 12.0 times out when downloading large packages. * pkgng: test jail creation logging less verbose `ezjail-admin` had been spewing every filename copied into the jail onto stderr, making the `ansible-test -v` logs hard to scroll through. Changed it so that ezjail output only shows up in the ansible task logs if `ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin` output is always logged to `/tmp/ezjail.log`. * pkgng: pass tests when package dependencies change Tests that install packages with dependencies were failing when those dependencies were not already installed, because the count of installed packages was greater than the count of requested to be installed packages. This change checks for a count of installed packages that is greater than or equal to the count of requested to be installed packages. Example: - Test installs packages `zsh` and `fish` - `fish` has a dependency on `pcre2` - `pkg` reports `Number of packages to be installed: 3` * pkgng: test annotation for single package Add/modify/remove annotation for a single package * pkgng: fix annotation operations Annotation has been broken at least since the migration to collections. There are some breaking typos and function argument omissions in the code with nothing in `git blame` but "Initial commit". New integration tests uncovered this breakage. Works now. * pkgng: test multiple annotations Test multiple annotations specified both in new (YAML list) syntax and old (comma-delimited) syntax. Rename some annotation test tags from the single-annotation tests to make sure that single and multiple annotation tests don't collide. * pkgng: test invalid annotate strings Ensure that some likely to occur, invalid strings given to the annotate module parameter 1. fail, 2. do not cause an exception, and 3. do not create any actual annotations on packages. * pkgng: fix check_mode for annotate Actions specified in the `annotate` parameter would always be performed, even if `check_mode=yes`. This commit fixes `check_mode` for the annotation functions and adds integration tests to ensure that check mode is honored in the future. * pkgng: call module.run_command with list Instead of calling `run_command` with a formatted string, call it with a list to maintain safer argument separation. Also, introduce a wrapper for `run_command`, `run_pkgng`, which manages the process environment and some common command line switches, based upon the module parameters. Introduced in this commit, also pass annotation values to `pkg annotate` via stdin, which is safer with long values than putting them in argv. * pkgng: update documentation to match annotate type Missed updating the documentation to match the change of the annotate parameter from comma-separated string to list of strings. * pkgng: fix syntax for Python 2 Seems *args, **kwargs have to be the last two arguments in Python 2 syntax. CI sanity tests were failing. * pkgng: oops, pkgsite should be from closure I put `pkgsite` as a keyword argument to `run_pkgng()', which wasn't correct at all and resulted it in capturing the second positional argument given by any caller. `pkgsite` should have been `p["pkgsite"]`, coming from the closure environment of `main()`. * pkgng: Fix changelog fragment quote formatting Co-authored-by: Felix Fontein <felix@fontein.de> * pkgng: add test prepare task Make sure test environment does not contain the test package. * pkgng: make integration test package more flexible Make integration test package building template-based, so more flexible if in the future the name of the test package, currently `zsh`, must change. * pkgng: convert generator to list for 2.9 Ansible 2.9 can't count items from a generator, so convert `select` filter output via `list` before passing to `count`. * pkgng: Ansible 2.9 has no "false" Jinja2 test Apparently Ansible 2.9 doesn't have the "false" test in Jinja2 contexts. Switching to use `rejectattr(...)` instead of `selectattr(..., "false")`. * pkgng: test pkgsite parameter * pkgng: add tests for chroot and rootdir params Refactor install tasks into an include file so they can be reused and tested with various parameters. * pkgng: clean up test package creation Make pkg json manifest more readable. Create package using FreeBSD's `pkg create` instead of manually using tar. This change also simplifies the manifest to a single file for the integration test role. * pkgng: fix #3428; install from local file Fixes a bug in which the module reported failure when installing from a local (to the target host) file path. Fixes #3428 * pkgng: changelog fragment formatting issue * pkgng: check for all test package extensions pkg recently changed file extensions, so for the tests to work on multiple recent versions of FreeBSD, we must check for `pkg create` output with varying filename. * Revert "pkgng: fix #3428; install from local file" As the module has invoked pkg with the `-g` flag for at least 7 years, I'm not sure when it was possible to install packages from files on the target host filesystem, because pkg rejects file paths when the `--glob` flag is enabled. I considered doing a rework of the pkg invocation to enable good support for installing from local files, but it looks like more of a job than for this PR. This reverts commit 5f94eac41ff040a79d4d00d2f723a9b3a148418e. * pkgng: Add minor_changes fragment for #3526 Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de>
2021-10-22 07:32:35 +02:00
- "'autoremoved' is in(pkgng_example7.msg)"
- pkgng_example7_cleanup is not changed
pkgng: add basic integration tests (#3526) * pkgng: package reinstallations count as changed `upgrade_packages()` only looked for the string "Number of packages to be upgraded", but the `pkg upgrade` command also reports "Number of packages to be reinstalled". Reinstallation occurs when package metadata other than version changes (e.g. build options, single architecture to `*` architecture). In any other respect, though, a required reinstallation is the same as an upgrade. * pkgng: check_mode should count queued actions Writing tests caught a bug in PR #3393, which enabled installing more than one package per `pkg` execution. In converting the module's install/upgrade code to a queue structure, check_mode got broken because the count of actions performed was only updated in the `if not check_mode` block that invokes `pkg`. This two-line change counts the number of actions in the queue when check mode is enabled. * pkgng: add basic integration tests Test installing a package Test installing a package into a jail * pkgng: test with zsh not bash package Had been using bash package, because it's not likely to disappear from the package repository any time soon. Turns out that bash is already installed on the Ansible community.general FreeBSD CI VM image, which makes the test fail. Zsh probably isn't going away any time soon, either, and likely won't be installed on the CI image. * pkgng: remove redundant test for docker container These tests should be skip/docker, but the test playbook also redundantly checked whether it was running in a docker container. Checking whether `ansible_facts.distribution` is `FreeBSD` is really sufficient to be sure whether the test is running in an environment that supports the `pkgng` module. * pkgng: add state=absent test Also renumber `jail=...` test to make diffs less noisy when adding more non-jailed tests. * pkgng: add state=latest idemptency test Add test between state=present and state=absent that ensures state=latest runs successfully on an already up-to-date package with changed=false. * pkgng: add state=latest test Including small filesize out-of-date package from FreeBSD 11 package repository, because FreeBSD 11 is currently EOL. This test might fail at some point in the future if the pkg utility in a FreeBSD version > 14 makes breaking changes that prevents it from installing older package formats. If that occurs, the fix is to replace `files/freebsd-release-manifests-20210413__FreeBSD_11.pkg` with the version of freebsd-release-manifests from the oldest non-breaking release of FreeBSD, and update the references to it in tasks/main.yml accordingly. * pkgng: use hand-generated test package Instead of relying on a broken-ish installation of an older package from FreeBSD 11, hand-generate a package named `zsh` with no contents and a version number of `0`. It can be installed on any architecture and any revision of FreeBSD sucessfully, and it will always be eligible for upgrade. * pkgng: CI seems to dislike plus-signs in filenames * pkgng: refactor renaming test package manifests refactored to make intent of adding '+' sign clearer * pkgng: refactor upgraded pattern matching Implement russoz's suggestion to put all variants in the pattern. * pkgng: add cached=yes test Changed idempotency test, because this covers both. * pkgng: test pkg works on any FreeBSD version Removing `ansible_distribution_version`, because the test out-of-date zsh package should install on any FreeBSD version. * pkgng: move FreeBSD tasks to imported file Refactoring tests for more reuse and easier readability. * pkgng: refactor tests for task reuse Several tests need to install an out-of-date package to test whether upgrades occur successfully, so this commit refactors out the generation of the test package. Also, factor out things like the name and path of the test package so that is more maintainable should the target test package (currently `zsh`) ever need to change. * pkgng: test install multiple packages Multiple packages should install with a single invocation of the `pkg` utility. * pkgng: handle space- and comma-separated lists The module expects a list of strings in the `name` parameter, but long-standing documentation showed space- and comma-delimited lists as a valid way of telling the module to act on multiple packages. Passing these lists through to the `pkg` command can have unexpected side-effects of upgrading packages when `state=present` rather than `state=latest` and could result in the module reporting the wrong number of packages for each action performed. * pkgng: test state=latest for mixed install/upgrade Test that a list of packages given, one not installed and one installed but out-of-date are handled correctly. * pkgng: use YAML lists for multiple packages I had been following the documentation examples, and specifiying multiple packages on one line. The right way to do it is with YAML list syntax. * pkgng: add test for autoremove=yes Install package with known dependencies, then remove it and ask autoremove to run. * pkgng: test autoremove=yes only on FreeBSD > 12 The CI test runner on FreeBSD 12.0 times out when downloading large packages. * pkgng: test jail creation logging less verbose `ezjail-admin` had been spewing every filename copied into the jail onto stderr, making the `ansible-test -v` logs hard to scroll through. Changed it so that ezjail output only shows up in the ansible task logs if `ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin` output is always logged to `/tmp/ezjail.log`. * pkgng: pass tests when package dependencies change Tests that install packages with dependencies were failing when those dependencies were not already installed, because the count of installed packages was greater than the count of requested to be installed packages. This change checks for a count of installed packages that is greater than or equal to the count of requested to be installed packages. Example: - Test installs packages `zsh` and `fish` - `fish` has a dependency on `pcre2` - `pkg` reports `Number of packages to be installed: 3` * pkgng: test annotation for single package Add/modify/remove annotation for a single package * pkgng: fix annotation operations Annotation has been broken at least since the migration to collections. There are some breaking typos and function argument omissions in the code with nothing in `git blame` but "Initial commit". New integration tests uncovered this breakage. Works now. * pkgng: test multiple annotations Test multiple annotations specified both in new (YAML list) syntax and old (comma-delimited) syntax. Rename some annotation test tags from the single-annotation tests to make sure that single and multiple annotation tests don't collide. * pkgng: test invalid annotate strings Ensure that some likely to occur, invalid strings given to the annotate module parameter 1. fail, 2. do not cause an exception, and 3. do not create any actual annotations on packages. * pkgng: fix check_mode for annotate Actions specified in the `annotate` parameter would always be performed, even if `check_mode=yes`. This commit fixes `check_mode` for the annotation functions and adds integration tests to ensure that check mode is honored in the future. * pkgng: call module.run_command with list Instead of calling `run_command` with a formatted string, call it with a list to maintain safer argument separation. Also, introduce a wrapper for `run_command`, `run_pkgng`, which manages the process environment and some common command line switches, based upon the module parameters. Introduced in this commit, also pass annotation values to `pkg annotate` via stdin, which is safer with long values than putting them in argv. * pkgng: update documentation to match annotate type Missed updating the documentation to match the change of the annotate parameter from comma-separated string to list of strings. * pkgng: fix syntax for Python 2 Seems *args, **kwargs have to be the last two arguments in Python 2 syntax. CI sanity tests were failing. * pkgng: oops, pkgsite should be from closure I put `pkgsite` as a keyword argument to `run_pkgng()', which wasn't correct at all and resulted it in capturing the second positional argument given by any caller. `pkgsite` should have been `p["pkgsite"]`, coming from the closure environment of `main()`. * pkgng: Fix changelog fragment quote formatting Co-authored-by: Felix Fontein <felix@fontein.de> * pkgng: add test prepare task Make sure test environment does not contain the test package. * pkgng: make integration test package more flexible Make integration test package building template-based, so more flexible if in the future the name of the test package, currently `zsh`, must change. * pkgng: convert generator to list for 2.9 Ansible 2.9 can't count items from a generator, so convert `select` filter output via `list` before passing to `count`. * pkgng: Ansible 2.9 has no "false" Jinja2 test Apparently Ansible 2.9 doesn't have the "false" test in Jinja2 contexts. Switching to use `rejectattr(...)` instead of `selectattr(..., "false")`. * pkgng: test pkgsite parameter * pkgng: add tests for chroot and rootdir params Refactor install tasks into an include file so they can be reused and tested with various parameters. * pkgng: clean up test package creation Make pkg json manifest more readable. Create package using FreeBSD's `pkg create` instead of manually using tar. This change also simplifies the manifest to a single file for the integration test role. * pkgng: fix #3428; install from local file Fixes a bug in which the module reported failure when installing from a local (to the target host) file path. Fixes #3428 * pkgng: changelog fragment formatting issue * pkgng: check for all test package extensions pkg recently changed file extensions, so for the tests to work on multiple recent versions of FreeBSD, we must check for `pkg create` output with varying filename. * Revert "pkgng: fix #3428; install from local file" As the module has invoked pkg with the `-g` flag for at least 7 years, I'm not sure when it was possible to install packages from files on the target host filesystem, because pkg rejects file paths when the `--glob` flag is enabled. I considered doing a rework of the pkg invocation to enable good support for installing from local files, but it looks like more of a job than for this PR. This reverts commit 5f94eac41ff040a79d4d00d2f723a9b3a148418e. * pkgng: Add minor_changes fragment for #3526 Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de>
2021-10-22 07:32:35 +02:00
##
## pkgng - example - single annotations
##
- name: Install and annotate single package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: '+ansibletest_example8=added'
register: pkgng_example8_add_annotation
- name: Should fail to add duplicate annotation
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: '+ansibletest_example8=duplicate'
ignore_errors: yes
register: pkgng_example8_add_annotation_failure
- name: Verify annotation is actually there
command: 'pkg annotate -q -S {{ pkgng_test_pkg_name }} ansibletest_example8'
register: pkgng_example8_add_annotation_verify
- name: Install and annotate single package (checkmode, not changed)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: '+ansibletest_example8=added'
check_mode: yes
register: pkgng_example8_add_annotation_checkmode_nochange
- name: Install and annotate single package (checkmode, changed)
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: '+ansibletest_example8_checkmode=added'
check_mode: yes
register: pkgng_example8_add_annotation_checkmode_change
- name: Verify check_mode did not add an annotation
command: 'pkg annotate -q -S {{ pkgng_test_pkg_name }} ansibletest_example8_checkmode'
register: pkgng_example8_add_annotation_checkmode_change_verify
- name: Modify annotation on single package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: ':ansibletest_example8=modified'
register: pkgng_example8_modify_annotation
- name: Should fail to modify missing annotation
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: ':ansiblemissing=modified'
ignore_errors: yes
register: pkgng_example8_modify_annotation_failure
- name: Verify annotation has been modified
command: 'pkg annotate -q -S {{ pkgng_test_pkg_name }} ansibletest_example8'
register: pkgng_example8_modify_annotation_verify
- name: Remove annotation on single package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: '-ansibletest_example8'
register: pkgng_example8_remove_annotation
- name: Verify annotation has been removed
command: 'pkg annotate -q -S {{ pkgng_test_pkg_name }} ansibletest_example8'
register: pkgng_example8_remove_annotation_verify
- name: Ensure pkgng annotations on single packages work correctly
assert:
that:
- pkgng_example8_add_annotation.changed
- pkgng_example8_add_annotation_failure.failed
- pkgng_example8_add_annotation_checkmode_nochange is not changed
- pkgng_example8_add_annotation_checkmode_change is changed
- 'pkgng_example8_add_annotation_checkmode_change_verify.stdout_lines | count == 0'
- 'pkgng_example8_add_annotation_verify.stdout_lines | first == "added"'
- pkgng_example8_modify_annotation.changed
- pkgng_example8_modify_annotation_failure.failed
- 'pkgng_example8_modify_annotation_verify.stdout_lines | first == "modified"'
- pkgng_example8_remove_annotation.changed
- 'pkgng_example8_remove_annotation_verify.stdout_lines | count == 0'
##
## pkgng - example - multiple annotations
##
- name: Annotate single package with multiple annotations
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation:
- '+ansibletest_example9_1=added'
- '+ansibletest_example9_2=added'
register: pkgng_example9_add_annotation
- name: Verify annotation is actually there
command: 'pkg info -q -A {{ pkgng_test_pkg_name }}'
register: pkgng_example9_add_annotation_verify
# Assert, below, tests that stdout includes:
# ```
# ansibletest_example9_1 : added
# ansibletest_example9_2 : added
# ```
- name: Multiple annotation operations on single package
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation:
- ':ansibletest_example9_1=modified'
- '+ansibletest_example9_3=added'
register: pkgng_example9_multiple_annotation
- name: Verify multiple operations succeeded
command: 'pkg info -q -A {{ pkgng_test_pkg_name }}'
register: pkgng_example9_multiple_annotation_verify
# Assert, below, tests that stdout includes:
# ```
# ansibletest_example9_1 : modified
# ansibletest_example9_2 : added
# ansibletest_example9_3 : added
# ```
- name: Add multiple annotations with old syntax
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: '+ansibletest_example9_4=added,+ansibletest_example9_5=added'
register: pkgng_example9_add_annotation_old
- name: Verify annotation is actually there
command: 'pkg info -q -A {{ pkgng_test_pkg_name }}'
register: pkgng_example9_add_annotation_old_verify
# Assert, below, tests that stdout includes:
# ```
# ansibletest_example9_4 : added
# ansibletest_example9_5 : added
# ```
- name: Ensure multiple annotations work correctly
assert:
that:
- pkgng_example9_add_annotation.changed
- '(pkgng_example9_add_annotation_verify.stdout_lines | select("match", "ansibletest_example9_[12]\s*:\s*added") | list | count) == 2'
- pkgng_example9_multiple_annotation.changed
- '(pkgng_example9_multiple_annotation_verify.stdout_lines | select("match", "ansibletest_example9_1\s*:\s*modified") | list | count) == 1'
- '(pkgng_example9_multiple_annotation_verify.stdout_lines | select("match", "ansibletest_example9_[23]\s*:\s*added") | list | count) == 2'
- pkgng_example9_add_annotation_old.changed
- '(pkgng_example9_add_annotation_old_verify.stdout_lines | select("match", "ansibletest_example9_[45]\s*:\s*added") | list | count) == 2'
##
## pkgng - example - invalid annotation strings
##
- name: Should fail on invalid annotate strings
pkgng:
name: '{{ pkgng_test_pkg_name }}'
annotation: '{{ item }}'
ignore_errors: yes
register: pkgng_example8_invalid_annotation_failure
loop:
- 'naked_string'
- '/invalid_operation'
- ',empty_first_tag=validsecond'
- '=notag'
- name: Verify invalid annotate strings did not add annotations
command: 'pkg info -q -A {{ pkgng_test_pkg_name }}'
register: pkgng_example8_invalid_annotation_verify
- name: Ensure invalid annotate strings fail safely
assert:
that:
# Invalid strings should not change anything
- '(pkgng_example8_invalid_annotation_failure.results | selectattr("changed") | list | count) == 0'
# Invalid strings should always fail
- '(pkgng_example8_invalid_annotation_failure.results | rejectattr("failed") | list | count) == 0'
# Invalid strings should not cause an exception
- '(pkgng_example8_invalid_annotation_failure.results | selectattr("exception", "defined") | list | count) == 0'
# Verify annotations are unaffected
- '(pkgng_example8_invalid_annotation_verify.stdout_lines | select("search", "(naked_string|invalid_operation|empty_first_tag|validsecond|notag)") | list | count) == 0'
##
## pkgng - example - pkgsite=...
##
# NOTE: testing for failure here to not have to set up our own
# or depend on a third-party, alternate package repo
- name: Should fail with invalid pkgsite
pkgng:
name: '{{ pkgng_test_pkg_name }}'
pkgsite: DoesNotExist
ignore_errors: yes
register: pkgng_example10_invalid_pkgsite_failure
- name: Ensure invalid pkgsite fails as expected
assert:
that:
- pkgng_example10_invalid_pkgsite_failure.failed
- 'pkgng_example10_invalid_pkgsite_failure.stdout is search("^No repositories are enabled.", multiline=True)'
##
## pkgng - example - Install single package in jail
##
- name: Test within jail
#
# NOTE: FreeBSD 12.0 test runner receives a "connection reset by peer" after ~20% downloaded so we are
# only running this on 12.1 or higher
#
# NOTE: FreeBSD 12.3 fails with some kernel mismatch for packages
# (someone with FreeBSD knowledge has to take a look)
#
# NOTE: FreeBSD 12.4 fails to update repositories because it cannot load certificates from /usr/share/keys/pkg/trusted
# (someone with FreeBSD knowledge has to take a look)
#
# NOTE: FreeBSD 13.0 fails to update the package catalogue for unknown reasons (someone with FreeBSD
# knowledge has to take a look)
#
# NOTE: FreeBSD 13.1 fails to update the package catalogue for unknown reasons (someone with FreeBSD
# knowledge has to take a look)
#
# NOTE: FreeBSD 13.2 fails to update the package catalogue for unknown reasons (someone with FreeBSD
# knowledge has to take a look)
#
# See also
# https://github.com/ansible-collections/community.general/issues/5795
when: >-
(ansible_distribution_version is version('12.01', '>=') and ansible_distribution_version is version('12.3', '<'))
or ansible_distribution_version is version('13.3', '>=')
pkgng: add basic integration tests (#3526) * pkgng: package reinstallations count as changed `upgrade_packages()` only looked for the string "Number of packages to be upgraded", but the `pkg upgrade` command also reports "Number of packages to be reinstalled". Reinstallation occurs when package metadata other than version changes (e.g. build options, single architecture to `*` architecture). In any other respect, though, a required reinstallation is the same as an upgrade. * pkgng: check_mode should count queued actions Writing tests caught a bug in PR #3393, which enabled installing more than one package per `pkg` execution. In converting the module's install/upgrade code to a queue structure, check_mode got broken because the count of actions performed was only updated in the `if not check_mode` block that invokes `pkg`. This two-line change counts the number of actions in the queue when check mode is enabled. * pkgng: add basic integration tests Test installing a package Test installing a package into a jail * pkgng: test with zsh not bash package Had been using bash package, because it's not likely to disappear from the package repository any time soon. Turns out that bash is already installed on the Ansible community.general FreeBSD CI VM image, which makes the test fail. Zsh probably isn't going away any time soon, either, and likely won't be installed on the CI image. * pkgng: remove redundant test for docker container These tests should be skip/docker, but the test playbook also redundantly checked whether it was running in a docker container. Checking whether `ansible_facts.distribution` is `FreeBSD` is really sufficient to be sure whether the test is running in an environment that supports the `pkgng` module. * pkgng: add state=absent test Also renumber `jail=...` test to make diffs less noisy when adding more non-jailed tests. * pkgng: add state=latest idemptency test Add test between state=present and state=absent that ensures state=latest runs successfully on an already up-to-date package with changed=false. * pkgng: add state=latest test Including small filesize out-of-date package from FreeBSD 11 package repository, because FreeBSD 11 is currently EOL. This test might fail at some point in the future if the pkg utility in a FreeBSD version > 14 makes breaking changes that prevents it from installing older package formats. If that occurs, the fix is to replace `files/freebsd-release-manifests-20210413__FreeBSD_11.pkg` with the version of freebsd-release-manifests from the oldest non-breaking release of FreeBSD, and update the references to it in tasks/main.yml accordingly. * pkgng: use hand-generated test package Instead of relying on a broken-ish installation of an older package from FreeBSD 11, hand-generate a package named `zsh` with no contents and a version number of `0`. It can be installed on any architecture and any revision of FreeBSD sucessfully, and it will always be eligible for upgrade. * pkgng: CI seems to dislike plus-signs in filenames * pkgng: refactor renaming test package manifests refactored to make intent of adding '+' sign clearer * pkgng: refactor upgraded pattern matching Implement russoz's suggestion to put all variants in the pattern. * pkgng: add cached=yes test Changed idempotency test, because this covers both. * pkgng: test pkg works on any FreeBSD version Removing `ansible_distribution_version`, because the test out-of-date zsh package should install on any FreeBSD version. * pkgng: move FreeBSD tasks to imported file Refactoring tests for more reuse and easier readability. * pkgng: refactor tests for task reuse Several tests need to install an out-of-date package to test whether upgrades occur successfully, so this commit refactors out the generation of the test package. Also, factor out things like the name and path of the test package so that is more maintainable should the target test package (currently `zsh`) ever need to change. * pkgng: test install multiple packages Multiple packages should install with a single invocation of the `pkg` utility. * pkgng: handle space- and comma-separated lists The module expects a list of strings in the `name` parameter, but long-standing documentation showed space- and comma-delimited lists as a valid way of telling the module to act on multiple packages. Passing these lists through to the `pkg` command can have unexpected side-effects of upgrading packages when `state=present` rather than `state=latest` and could result in the module reporting the wrong number of packages for each action performed. * pkgng: test state=latest for mixed install/upgrade Test that a list of packages given, one not installed and one installed but out-of-date are handled correctly. * pkgng: use YAML lists for multiple packages I had been following the documentation examples, and specifiying multiple packages on one line. The right way to do it is with YAML list syntax. * pkgng: add test for autoremove=yes Install package with known dependencies, then remove it and ask autoremove to run. * pkgng: test autoremove=yes only on FreeBSD > 12 The CI test runner on FreeBSD 12.0 times out when downloading large packages. * pkgng: test jail creation logging less verbose `ezjail-admin` had been spewing every filename copied into the jail onto stderr, making the `ansible-test -v` logs hard to scroll through. Changed it so that ezjail output only shows up in the ansible task logs if `ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin` output is always logged to `/tmp/ezjail.log`. * pkgng: pass tests when package dependencies change Tests that install packages with dependencies were failing when those dependencies were not already installed, because the count of installed packages was greater than the count of requested to be installed packages. This change checks for a count of installed packages that is greater than or equal to the count of requested to be installed packages. Example: - Test installs packages `zsh` and `fish` - `fish` has a dependency on `pcre2` - `pkg` reports `Number of packages to be installed: 3` * pkgng: test annotation for single package Add/modify/remove annotation for a single package * pkgng: fix annotation operations Annotation has been broken at least since the migration to collections. There are some breaking typos and function argument omissions in the code with nothing in `git blame` but "Initial commit". New integration tests uncovered this breakage. Works now. * pkgng: test multiple annotations Test multiple annotations specified both in new (YAML list) syntax and old (comma-delimited) syntax. Rename some annotation test tags from the single-annotation tests to make sure that single and multiple annotation tests don't collide. * pkgng: test invalid annotate strings Ensure that some likely to occur, invalid strings given to the annotate module parameter 1. fail, 2. do not cause an exception, and 3. do not create any actual annotations on packages. * pkgng: fix check_mode for annotate Actions specified in the `annotate` parameter would always be performed, even if `check_mode=yes`. This commit fixes `check_mode` for the annotation functions and adds integration tests to ensure that check mode is honored in the future. * pkgng: call module.run_command with list Instead of calling `run_command` with a formatted string, call it with a list to maintain safer argument separation. Also, introduce a wrapper for `run_command`, `run_pkgng`, which manages the process environment and some common command line switches, based upon the module parameters. Introduced in this commit, also pass annotation values to `pkg annotate` via stdin, which is safer with long values than putting them in argv. * pkgng: update documentation to match annotate type Missed updating the documentation to match the change of the annotate parameter from comma-separated string to list of strings. * pkgng: fix syntax for Python 2 Seems *args, **kwargs have to be the last two arguments in Python 2 syntax. CI sanity tests were failing. * pkgng: oops, pkgsite should be from closure I put `pkgsite` as a keyword argument to `run_pkgng()', which wasn't correct at all and resulted it in capturing the second positional argument given by any caller. `pkgsite` should have been `p["pkgsite"]`, coming from the closure environment of `main()`. * pkgng: Fix changelog fragment quote formatting Co-authored-by: Felix Fontein <felix@fontein.de> * pkgng: add test prepare task Make sure test environment does not contain the test package. * pkgng: make integration test package more flexible Make integration test package building template-based, so more flexible if in the future the name of the test package, currently `zsh`, must change. * pkgng: convert generator to list for 2.9 Ansible 2.9 can't count items from a generator, so convert `select` filter output via `list` before passing to `count`. * pkgng: Ansible 2.9 has no "false" Jinja2 test Apparently Ansible 2.9 doesn't have the "false" test in Jinja2 contexts. Switching to use `rejectattr(...)` instead of `selectattr(..., "false")`. * pkgng: test pkgsite parameter * pkgng: add tests for chroot and rootdir params Refactor install tasks into an include file so they can be reused and tested with various parameters. * pkgng: clean up test package creation Make pkg json manifest more readable. Create package using FreeBSD's `pkg create` instead of manually using tar. This change also simplifies the manifest to a single file for the integration test role. * pkgng: fix #3428; install from local file Fixes a bug in which the module reported failure when installing from a local (to the target host) file path. Fixes #3428 * pkgng: changelog fragment formatting issue * pkgng: check for all test package extensions pkg recently changed file extensions, so for the tests to work on multiple recent versions of FreeBSD, we must check for `pkg create` output with varying filename. * Revert "pkgng: fix #3428; install from local file" As the module has invoked pkg with the `-g` flag for at least 7 years, I'm not sure when it was possible to install packages from files on the target host filesystem, because pkg rejects file paths when the `--glob` flag is enabled. I considered doing a rework of the pkg invocation to enable good support for installing from local files, but it looks like more of a job than for this PR. This reverts commit 5f94eac41ff040a79d4d00d2f723a9b3a148418e. * pkgng: Add minor_changes fragment for #3526 Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de>
2021-10-22 07:32:35 +02:00
block:
- name: Setup testjail
include_tasks: setup-testjail.yml
pkgng: add basic integration tests (#3526) * pkgng: package reinstallations count as changed `upgrade_packages()` only looked for the string "Number of packages to be upgraded", but the `pkg upgrade` command also reports "Number of packages to be reinstalled". Reinstallation occurs when package metadata other than version changes (e.g. build options, single architecture to `*` architecture). In any other respect, though, a required reinstallation is the same as an upgrade. * pkgng: check_mode should count queued actions Writing tests caught a bug in PR #3393, which enabled installing more than one package per `pkg` execution. In converting the module's install/upgrade code to a queue structure, check_mode got broken because the count of actions performed was only updated in the `if not check_mode` block that invokes `pkg`. This two-line change counts the number of actions in the queue when check mode is enabled. * pkgng: add basic integration tests Test installing a package Test installing a package into a jail * pkgng: test with zsh not bash package Had been using bash package, because it's not likely to disappear from the package repository any time soon. Turns out that bash is already installed on the Ansible community.general FreeBSD CI VM image, which makes the test fail. Zsh probably isn't going away any time soon, either, and likely won't be installed on the CI image. * pkgng: remove redundant test for docker container These tests should be skip/docker, but the test playbook also redundantly checked whether it was running in a docker container. Checking whether `ansible_facts.distribution` is `FreeBSD` is really sufficient to be sure whether the test is running in an environment that supports the `pkgng` module. * pkgng: add state=absent test Also renumber `jail=...` test to make diffs less noisy when adding more non-jailed tests. * pkgng: add state=latest idemptency test Add test between state=present and state=absent that ensures state=latest runs successfully on an already up-to-date package with changed=false. * pkgng: add state=latest test Including small filesize out-of-date package from FreeBSD 11 package repository, because FreeBSD 11 is currently EOL. This test might fail at some point in the future if the pkg utility in a FreeBSD version > 14 makes breaking changes that prevents it from installing older package formats. If that occurs, the fix is to replace `files/freebsd-release-manifests-20210413__FreeBSD_11.pkg` with the version of freebsd-release-manifests from the oldest non-breaking release of FreeBSD, and update the references to it in tasks/main.yml accordingly. * pkgng: use hand-generated test package Instead of relying on a broken-ish installation of an older package from FreeBSD 11, hand-generate a package named `zsh` with no contents and a version number of `0`. It can be installed on any architecture and any revision of FreeBSD sucessfully, and it will always be eligible for upgrade. * pkgng: CI seems to dislike plus-signs in filenames * pkgng: refactor renaming test package manifests refactored to make intent of adding '+' sign clearer * pkgng: refactor upgraded pattern matching Implement russoz's suggestion to put all variants in the pattern. * pkgng: add cached=yes test Changed idempotency test, because this covers both. * pkgng: test pkg works on any FreeBSD version Removing `ansible_distribution_version`, because the test out-of-date zsh package should install on any FreeBSD version. * pkgng: move FreeBSD tasks to imported file Refactoring tests for more reuse and easier readability. * pkgng: refactor tests for task reuse Several tests need to install an out-of-date package to test whether upgrades occur successfully, so this commit refactors out the generation of the test package. Also, factor out things like the name and path of the test package so that is more maintainable should the target test package (currently `zsh`) ever need to change. * pkgng: test install multiple packages Multiple packages should install with a single invocation of the `pkg` utility. * pkgng: handle space- and comma-separated lists The module expects a list of strings in the `name` parameter, but long-standing documentation showed space- and comma-delimited lists as a valid way of telling the module to act on multiple packages. Passing these lists through to the `pkg` command can have unexpected side-effects of upgrading packages when `state=present` rather than `state=latest` and could result in the module reporting the wrong number of packages for each action performed. * pkgng: test state=latest for mixed install/upgrade Test that a list of packages given, one not installed and one installed but out-of-date are handled correctly. * pkgng: use YAML lists for multiple packages I had been following the documentation examples, and specifiying multiple packages on one line. The right way to do it is with YAML list syntax. * pkgng: add test for autoremove=yes Install package with known dependencies, then remove it and ask autoremove to run. * pkgng: test autoremove=yes only on FreeBSD > 12 The CI test runner on FreeBSD 12.0 times out when downloading large packages. * pkgng: test jail creation logging less verbose `ezjail-admin` had been spewing every filename copied into the jail onto stderr, making the `ansible-test -v` logs hard to scroll through. Changed it so that ezjail output only shows up in the ansible task logs if `ansible_verbosity > 1` (`-vv...`). Full `ezjail-admin` output is always logged to `/tmp/ezjail.log`. * pkgng: pass tests when package dependencies change Tests that install packages with dependencies were failing when those dependencies were not already installed, because the count of installed packages was greater than the count of requested to be installed packages. This change checks for a count of installed packages that is greater than or equal to the count of requested to be installed packages. Example: - Test installs packages `zsh` and `fish` - `fish` has a dependency on `pcre2` - `pkg` reports `Number of packages to be installed: 3` * pkgng: test annotation for single package Add/modify/remove annotation for a single package * pkgng: fix annotation operations Annotation has been broken at least since the migration to collections. There are some breaking typos and function argument omissions in the code with nothing in `git blame` but "Initial commit". New integration tests uncovered this breakage. Works now. * pkgng: test multiple annotations Test multiple annotations specified both in new (YAML list) syntax and old (comma-delimited) syntax. Rename some annotation test tags from the single-annotation tests to make sure that single and multiple annotation tests don't collide. * pkgng: test invalid annotate strings Ensure that some likely to occur, invalid strings given to the annotate module parameter 1. fail, 2. do not cause an exception, and 3. do not create any actual annotations on packages. * pkgng: fix check_mode for annotate Actions specified in the `annotate` parameter would always be performed, even if `check_mode=yes`. This commit fixes `check_mode` for the annotation functions and adds integration tests to ensure that check mode is honored in the future. * pkgng: call module.run_command with list Instead of calling `run_command` with a formatted string, call it with a list to maintain safer argument separation. Also, introduce a wrapper for `run_command`, `run_pkgng`, which manages the process environment and some common command line switches, based upon the module parameters. Introduced in this commit, also pass annotation values to `pkg annotate` via stdin, which is safer with long values than putting them in argv. * pkgng: update documentation to match annotate type Missed updating the documentation to match the change of the annotate parameter from comma-separated string to list of strings. * pkgng: fix syntax for Python 2 Seems *args, **kwargs have to be the last two arguments in Python 2 syntax. CI sanity tests were failing. * pkgng: oops, pkgsite should be from closure I put `pkgsite` as a keyword argument to `run_pkgng()', which wasn't correct at all and resulted it in capturing the second positional argument given by any caller. `pkgsite` should have been `p["pkgsite"]`, coming from the closure environment of `main()`. * pkgng: Fix changelog fragment quote formatting Co-authored-by: Felix Fontein <felix@fontein.de> * pkgng: add test prepare task Make sure test environment does not contain the test package. * pkgng: make integration test package more flexible Make integration test package building template-based, so more flexible if in the future the name of the test package, currently `zsh`, must change. * pkgng: convert generator to list for 2.9 Ansible 2.9 can't count items from a generator, so convert `select` filter output via `list` before passing to `count`. * pkgng: Ansible 2.9 has no "false" Jinja2 test Apparently Ansible 2.9 doesn't have the "false" test in Jinja2 contexts. Switching to use `rejectattr(...)` instead of `selectattr(..., "false")`. * pkgng: test pkgsite parameter * pkgng: add tests for chroot and rootdir params Refactor install tasks into an include file so they can be reused and tested with various parameters. * pkgng: clean up test package creation Make pkg json manifest more readable. Create package using FreeBSD's `pkg create` instead of manually using tar. This change also simplifies the manifest to a single file for the integration test role. * pkgng: fix #3428; install from local file Fixes a bug in which the module reported failure when installing from a local (to the target host) file path. Fixes #3428 * pkgng: changelog fragment formatting issue * pkgng: check for all test package extensions pkg recently changed file extensions, so for the tests to work on multiple recent versions of FreeBSD, we must check for `pkg create` output with varying filename. * Revert "pkgng: fix #3428; install from local file" As the module has invoked pkg with the `-g` flag for at least 7 years, I'm not sure when it was possible to install packages from files on the target host filesystem, because pkg rejects file paths when the `--glob` flag is enabled. I considered doing a rework of the pkg invocation to enable good support for installing from local files, but it looks like more of a job than for this PR. This reverts commit 5f94eac41ff040a79d4d00d2f723a9b3a148418e. * pkgng: Add minor_changes fragment for #3526 Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de>
2021-10-22 07:32:35 +02:00
- name: Install package in jail as rootdir
include_tasks: install_single_package.yml
vars:
pkgng_test_rootdir: /usr/jails/testjail
pkgng_test_install_prefix: /usr/jails/testjail
pkgng_test_install_cleanup: yes
- name: Install package in jail
include_tasks: install_single_package.yml
vars:
pkgng_test_jail: testjail
pkgng_test_install_prefix: /usr/jails/testjail
pkgng_test_install_cleanup: yes
- name: Install package in jail as chroot
include_tasks: install_single_package.yml
vars:
pkgng_test_chroot: /usr/jails/testjail
pkgng_test_install_prefix: /usr/jails/testjail
pkgng_test_install_cleanup: yes
always:
- name: Stop and remove testjail
failed_when: false
changed_when: false
command: "ezjail-admin delete -wf testjail"