improve linting

tasks/manual_install_websvn.yml

@@ -22,5 +22,6 @@
     src: "{{ websvn__config_src }}"
     dest: "/var/www/websvn/include/config.php"
     backup: true
+    mode: 0644
     owner: "{{ websvn__web_user }}"
     group: "{{ websvn__web_group }}"

tasks/versioncheck.yml

@@ -1,7 +1,10 @@
 ---
+# Copyright (c) 2021 L3D <l3d@c3woc.de>
+# this file is released with the MIT license.
+# License: https://github.com/roles-ansible/ansible_role_template/blob/main/LICENSE
 - name: Create directory for versionscheck
   become: true
-  file:
+  ansible.builtin.file:
     path: '/etc/.ansible-version'
     state: directory
     mode: 0755
@@ -9,36 +12,33 @@
 
 - name: check playbook version
   become: true
-  slurp:
+  ansible.builtin.slurp:
     src: "/etc/.ansible-version/{{ playbook_version_path }}"
   register: playbook_version
   when: submodules_versioncheck|bool
+  ignore_errors: true
   failed_when: false
 
 - name: Print remote role version
-  debug:
+  ansible.builtin.debug:
     msg: "Remote role version: {{ playbook_version.content | default('Y3VycmVudGx5IG5vdCBkZXBsb3llZAo=') | b64decode | string }}"
   when: submodules_versioncheck|bool
 
 - name: Print locale role version
-  debug:
+  ansible.builtin.debug:
     msg: "Local role version: '{{ playbook_version_number|string }}'."
   when: submodules_versioncheck|bool
 
 - name: Check if your version is outdated
-  fail:
+  ansible.builtin.fail:
     msg: "Your ansible module has the version '{{ playbook_version_number }}' and is outdated. You need to update it!"
   when:
     - playbook_version.content|default("Mgo=")|b64decode|int - 1 >= playbook_version_number|int and submodules_versioncheck|bool
 
-- name: check if '/etc/ansible-version/' is empty
-  find:
-    paths: '/etc/ansible-version/'
-  register: filesFound
-
 - name: write new version to remote disk
   become: true
-  copy:
+  ansible.builtin.copy:
     content: "{{ playbook_version_number }}"
     dest: "/etc/.ansible-version/{{ playbook_version_path }}"
+    mode: '0644'
   when: submodules_versioncheck|bool

vars/main.yml

@@ -13,6 +13,6 @@ websvn__packages:
 
 
 # versionscheck
-playbook_version_number: 14 # should be over ninethousand
+playbook_version_number: 15  # should be over ninethousand
 playbook_version_path: 'role-websvn_roles-ansible_github.com.version'