1
0
Fork 0
mirror of https://github.com/roles-ansible/ansible_role_restic.git synced 2024-12-11 23:41:32 +01:00

Update delete_legacy_cron_entry.yml

Fixed (SCHEDULE) (OLD) check tainting the play recap as well as the assumption that cron_delete.failed will be defined.

Signed-off-by: Jeremy Hettenhouser <jhettenh@gmail.com>
This commit is contained in:
Jeremy Hettenhouser 2023-03-21 20:18:23 -04:00 committed by GitHub
parent c62e2a4027
commit ba17cc6657
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -6,6 +6,10 @@
fail_msg: "[ERROR] Youre ansible version is above 2.12.0" fail_msg: "[ERROR] Youre ansible version is above 2.12.0"
success_msg: "Congratulations. You are using ansible version {{ ansible_version.full }}" success_msg: "Congratulations. You are using ansible version {{ ansible_version.full }}"
delegate_to: localhost delegate_to: localhost
when:
- ansible_service_mgr != 'systemd' or restic_force_cron | default(false) or restic_schedule_type == "cronjob"
register: old_af
failed_when: false
ignore_errors: true ignore_errors: true
- name: (SCHEDULE) (OLD) try to remove entries from /etc/crontab - name: (SCHEDULE) (OLD) try to remove entries from /etc/crontab
@ -18,32 +22,32 @@
weekday: '{{ item.schedule_weekday | default("*") }}' weekday: '{{ item.schedule_weekday | default("*") }}'
month: '{{ item.schedule_month | default("*") }}' month: '{{ item.schedule_month | default("*") }}'
state: absent state: absent
cron_file: '/etc/crontab' cron_file: "/etc/crontab"
user: 'root' user: "root"
no_log: "{{ restic_no_log }}" no_log: "{{ restic_no_log }}"
with_items: '{{ restic_backups }}' with_items: "{{ restic_backups }}"
when: when:
- restic_create_schedule | bool - restic_create_schedule | bool
- item.name is defined - item.name is defined
- item.scheduled | default(false) - item.scheduled | default(false)
- ansible_service_mgr != 'systemd' or restic_force_cron | default(false) or restic_schedule_type == "cronjob" - old_af.success_msg is defined
register: cron_delete register: cron_delete
failed_when: false failed_when: false
- name: "(SCHEDULE) (OLD) make sure do1jlr.restic backup script is not in /etc/crontab" - name: "(SCHEDULE) (OLD) make sure do1jlr.restic backup script is not in /etc/crontab"
become: true become: true
ansible.builtin.lineinfile: ansible.builtin.lineinfile:
path: '/etc/crontab' path: "/etc/crontab"
state: absent state: absent
search_string: "do1jlr.restic backup {{ item.name }}" search_string: "do1jlr.restic backup {{ item.name }}"
when: cron_delete.failed when: cron_delete.failed is defined and cron_delete.failed
with_items: '{{ restic_backups }}' with_items: "{{ restic_backups }}"
- name: "(SCHEDULE) (OLD) make sure restic script is not in /etc/crontab" - name: "(SCHEDULE) (OLD) make sure restic script is not in /etc/crontab"
become: true become: true
ansible.builtin.lineinfile: ansible.builtin.lineinfile:
path: '/etc/crontab' path: "/etc/crontab"
state: absent state: absent
search_string: "{{ restic_script_dir }}/backup-{{ item.name | replace(' ', '') }}.sh" search_string: "{{ restic_script_dir }}/backup-{{ item.name | replace(' ', '') }}.sh"
when: cron_delete.failed when: cron_delete.failed is defined and cron_delete.failed
with_items: '{{ restic_backups }}' with_items: "{{ restic_backups }}"