Update yamllint and ansible-lint

.github/FUNDING.yml

@@ -1,4 +1,6 @@
-# Feel free to add yourself after && during participating at this repo!
+---
+# Feel free to add yourself if you maintain this repo
+# or participate in a way that you have the feeling that you belong there ;-)
 
 github: [do1jlr]
 liberapay: L3D

.github/workflows/ansible-debian-buster.yml

@@ -1,5 +1,7 @@
+---
 name: Ansible check debian:buster
 
+# yamllint disable-line rule:truthy
 on: [push, pull_request]
 
 jobs:
@@ -8,9 +10,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: ansible check with debian:buster
+      - name: ansible check with debian:buster
-      uses: roles-ansible/check-ansible-debian-buster-action@master
+        uses: roles-ansible/check-ansible-debian-buster-action@master
-      with:
+        with:
-        targets: "./"
+          targets: "./"

.github/workflows/ansible-debian-latest.yml

@@ -1,5 +1,7 @@
+---
 name: Ansible check debian:latest
 
+# yamllint disable-line rule:truthy
 on: [push, pull_request]
 
 jobs:
@@ -8,9 +10,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: ansible check with debian:latest
+      - name: ansible check with debian:latest
-      uses: roles-ansible/check-ansible-debian-latest-action@master
+        uses: roles-ansible/check-ansible-debian-latest-action@master
-      with:
+        with:
-        targets: "./"
+          targets: "./"

.github/workflows/ansible-debian-stable.yml

@@ -1,5 +1,7 @@
+---
 name: Ansible check debian:stable
 
+# yamllint disable-line rule:truthy
 on: [push, pull_request]
 
 jobs:
@@ -8,9 +10,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: ansible check with debian:stable
+      - name: ansible check with debian:stable
-      uses: roles-ansible/check-ansible-debian-stable-action@master
+        uses: roles-ansible/check-ansible-debian-stable-action@master
-      with:
+        with:
-        targets: "./"
+          targets: "./"

.github/workflows/ansible-debian-stretch.yml

@@ -1,5 +1,7 @@
+---
 name: Ansible check debian:stretch
 
+# yamllint disable-line rule:truthy
 on: [push, pull_request]
 
 jobs:
@@ -8,9 +10,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: ansible check with debian:stretch
+      - name: ansible check with debian:stretch
-      uses: roles-ansible/check-ansible-debian-stretch-action@master
+        uses: roles-ansible/check-ansible-debian-stretch-action@master
-      with:
+        with:
-        targets: "./"
+          targets: "./"

.github/workflows/ansible-linting-check.yml

@@ -1,5 +1,7 @@
+---
 name: Ansible Lint check
 
+# yamllint disable-line rule:truthy
 on: [push, pull_request]
 
 jobs:
@@ -8,13 +10,13 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: Lint Ansible Playbook
+      - name: Lint Ansible Playbook
-      uses: ansible/ansible-lint-action@master
+        uses: ansible/ansible-lint-action@master
-      with:
+        with:
-        targets: "."
+          targets: "."
-        # [required]
+          # [required]
-        # Paths to ansible files (i.e., playbooks, tasks, handlers etc..)
+          # Paths to ansible files (i.e., playbooks, tasks, handlers etc..)
-        args: ""
+          args: ""
-        # [optional]
+          # [optional]

.github/workflows/ansible-ubuntu-bionic.yml

@@ -1,5 +1,7 @@
+---
 name: Ansible check ubuntu:bionic
 
+# yamllint disable-line rule:truthy
 on: [push, pull_request]
 
 jobs:
@@ -8,9 +10,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: ansible check with ubuntu:bionic
+      - name: ansible check with ubuntu:bionic
-      uses: roles-ansible/check-ansible-ubuntu-bionic-action@master
+        uses: roles-ansible/check-ansible-ubuntu-bionic-action@master
-      with:
+        with:
-        targets: "./"
+          targets: "./"

.github/workflows/ansible-ubuntu-latest.yml

@@ -1,5 +1,7 @@
+---
 name: Ansible check ubuntu:latest
 
+# yamllint disable-line rule:truthy
 on: [push, pull_request]
 
 jobs:
@@ -8,9 +10,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v2
 
-    - name: ansible check with ubuntu:latest
+      - name: ansible check with ubuntu:latest
-      uses: roles-ansible/check-ansible-ubuntu-latest-action@master
+        uses: roles-ansible/check-ansible-ubuntu-latest-action@master
-      with:
+        with:
-        targets: "./"
+          targets: "./"

.github/workflows/yamllint.yaml

@@ -0,0 +1,22 @@
+---
+name: 'Yamllint GitHub Actions'
+
+# yamllint disable-line rule:truthy
+on: [push, pull_request]
+
+jobs:
+  yamllint:
+    name: 'Yamllint'
+    runs-on: ubuntu-latest
+    steps:
+      - name: 'Checkout'
+        uses: actions/checkout@master
+      - name: 'Yamllint'
+        uses: karancode/yamllint-github-action@master
+        with:
+          yamllint_file_or_dir: '.'
+          yamllint_config_filepath: './.yamllint'
+          yamllint_strict: false
+          yamllint_comment: true
+#       env:
+#         GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }

.travis.yml

@@ -1,31 +0,0 @@
----
-language: python
-python: "2.7"
-
-# Use the new container infrastructure
-sudo: false
-
-# Install ansible
-addons:
-  apt:
-    packages:
-    - python-pip
-
-install:
-  # Install ansible
-  - pip install ansible
-
-  # Check ansible version
-  - ansible --version
-
-  # Create ansible.cfg with correct roles_path
-  - printf '[defaults]\nroles_path=../' >ansible.cfg
-  - printf '---\n- hosts: localhost\n  remote_user: root\n  roles:\n    - .' >test.yml
-  - printf 'localhost' >hosts.ini
-
-script:
-  # Basic role syntax check
-  - ansible-playbook test.yml -i hosts.ini --syntax-check
-
-notifications:
-  webhooks: https://galaxy.ansible.com/api/v1/notifications/

.yamllint

@@ -0,0 +1,8 @@
+---
+extends: default
+
+rules:
+  # 150 chars should be enough, but don't fail if a line is longer
+  line-length:
+    max: 150
+    level: warning

tasks/installation.yml

@@ -4,7 +4,7 @@
   apt:
     name: apt-transport-https
     state: "{{ goaccess__state }}"
-    update_cache: yes
+    update_cache: true
 
 - name: add goaccess apt_key
   become: true
@@ -24,5 +24,5 @@
   apt:
     name: goaccess
     state: "{{ goaccess__state }}"
-    update_cache: yes
+    update_cache: true
     cache_valid_time: 3600

tasks/versioncheck.yml

@@ -13,7 +13,7 @@
     src: "/etc/.ansible-version/{{ playbook_version_path }}"
   register: playbook_version
   when: submodules_versioncheck|bool
-  ignore_errors: yes
+  ignore_errors: true
   failed_when: false
 
 - name: Print remote role version

vars/main.yml

@@ -1,4 +1,4 @@
 ---
 # versionscheck
-playbook_version_number: 02 # should be a integer
+playbook_version_number: 03  # should be a integer
-playbook_version_path: 'role-<some_unique_string>.version'
+playbook_version_path: 'role-goaccess_roles-ansible_github.version'