Merge pull request #114 from roles-ansible/1.20

Refactor setting.Other

.github/workflows/ansible-linting-check.yml

@@ -2,22 +2,22 @@
 name: Ansible Lint check
 
 # yamllint disable-line rule:truthy
-on:
+on: [push, pull_request]
-  push:
-    branches: '*'
-  pull_request:
-    branches: '*'
 
 jobs:
   build:
-
+    name: Ansible Lint
     runs-on: ubuntu-latest
 
     steps:
       - name: 'checkout git repo'
         uses: actions/checkout@v3
+        with:
+          lfs: true
+          submodules: false
+          fetch-depth: 0
 
       - name: 'Lint Ansible Playbook'
         uses: ansible/ansible-lint-action@v6
         with:
-          targets: "."
+          path: "."

README.md

@@ -313,7 +313,6 @@ Either you define exactly which release you install. Or you use the option ``lat
 ### Other ([other](https://docs.gitea.io/en-us/config-cheat-sheet/#other-other))
 | variable name | default value | description |
 | ------------- | ------------- | ----------- |
-| `gitea_other_show_footer_branding` | `false` | Show Gitea branding in the footer. |
 | `gitea_other_show_footer_version` | `true` | Show Gitea and Go version information in the footer. |
 | `gitea_other_show_footer_template_load_time` | `true` | Show time of template execution in the footer. |
 | `gitea_other_enable_sitemap` | `true` | Generate sitemap. |

defaults/main.yml

@@ -242,7 +242,6 @@ gitea_actions_extra: ''
 
 # Other (other)
 # -> https://docs.gitea.io/en-us/config-cheat-sheet/#other-other
-gitea_other_show_footer_branding: false
 gitea_other_show_footer_version: true
 gitea_other_show_footer_template_load_time: true
 gitea_other_enable_sitemap: true

templates/gitea.ini.j2

@@ -288,7 +288,6 @@ DEFAULT_ACTIONS_URL = {{ gitea_actions_default_actions_url }}
 ; Other (other)
 ; -> https://docs.gitea.io/en-us/config-cheat-sheet/#other-other
 [other]
-SHOW_FOOTER_BRANDING           = {{ gitea_other_show_footer_branding | ternary('true', 'false') }}
 SHOW_FOOTER_VERSION            = {{ gitea_other_show_footer_version | ternary('true', 'false') }}
 SHOW_FOOTER_TEMPLATE_LOAD_TIME = {{ gitea_other_show_footer_template_load_time | ternary('true', 'false') }}
 ENABLE_SITEMAP                 = {{ gitea_other_enable_sitemap | ternary('true', 'false') }}

vars/main.yml

@@ -62,5 +62,5 @@ transfer_custom_footer:
     - 'files/gitea_footer/extra_links_footer.tmpl'
     - 'files/extra_links_footer.tmpl'
 
-playbook_version_number: 48  # should be int
+playbook_version_number: 49  # should be int
 playbook_version_path: 'do1jlr.gitea.version'